From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Tor Arne Vestbø" <torarnv@gmail.com>
Cc: git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: Re: [JGIT PATCH] Fix AbstractTreeIterator path comparion betwen 'a' and 'a/b'
Date: Tue, 3 Feb 2009 08:15:39 -0800 [thread overview]
Message-ID: <20090203161539.GV26880@spearce.org> (raw)
In-Reply-To: <1233605617-14513-1-git-send-email-torarnv@gmail.com>
Tor Arne Vestbø <torarnv@gmail.com> wrote:
> The occurance of a '/' as the next character in the longer path
> does not neccecarily mean the two paths are equal, for example
> when the longer path has more components following the '/'.
>
> Signed-off-by: Tor Arne Vestbø <torarnv@gmail.com>
> ---
> .../jgit/treewalk/AbstractTreeIteratorTest.java | 93 ++++++++++++++++++++
> .../jgit/treewalk/AbstractTreeIterator.java | 4 +-
> 2 files changed, 95 insertions(+), 2 deletions(-)
> create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/treewalk/AbstractTreeIteratorTest.java
*sigh*
I can't get Eclipse to run this test. Every time I try it comes
up with a CNFE:
Class not found org.spearce.jgit.treewalk.AbstractTreeIteratorTest
java.lang.ClassNotFoundException: org.spearce.jgit.treewalk.AbstractTreeIteratorTest
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
Aside from this test not running, Eclipse says the tests pass. But
Maven tells another story:
(cd jgit-maven/jgit && mvn clean package)
...
Failed tests:
testNoDF_NoGap(org.spearce.jgit.treewalk.NameConflictTreeWalkTest)
testDF_GapByOne(org.spearce.jgit.treewalk.NameConflictTreeWalkTest)
testDF_SkipsSeenSubtree(org.spearce.jgit.treewalk.NameConflictTreeWalkTest)
Tests run: 773, Failures: 3, Errors: 0, Skipped: 0
Yet under Eclipse this test says its fine. But Maven actually
managed to run your new test case, where Eclipse didn't.
*confused*
--
Shawn.
next prev parent reply other threads:[~2009-02-03 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 20:13 [JGIT PATCH] Fix AbstractTreeIterator path comparion betwen 'a' and 'a/b' Tor Arne Vestbø
2009-02-03 16:15 ` Shawn O. Pearce [this message]
2009-02-03 16:36 ` Tor Arne Vestbø
2009-02-03 17:03 ` Shawn O. Pearce
2009-02-03 17:10 ` Tor Arne Vestbø
2009-02-03 17:20 ` [JGIT PATCH v2] Add a few test cases for AbstractTreeIterator's pathCompare Tor Arne Vestbø
2009-02-03 16:57 ` [JGIT PATCH] Fix AbstractTreeIterator path comparion betwen 'a' and 'a/b' Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203161539.GV26880@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=torarnv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).