From: Don Zickus <dzickus@redhat.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] apply: fix access to an uninitialized mode variable, found by valgrind
Date: Wed, 4 Feb 2009 09:36:34 -0500 [thread overview]
Message-ID: <20090204143634.GY3827@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902040249030.9822@pacific.mpi-cbg.de>
On Wed, Feb 04, 2009 at 02:50:15AM +0100, Johannes Schindelin wrote:
> When 'tpatch' was initialized successfully, st_mode was already taken
> from the previous diff. We should not try to override it with data
> from an lstat() that was never called.
heh, oops. thanks.
Acked-by: Don Zickus <dzickus@redhat.com>
next prev parent reply other threads:[~2009-02-04 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233712140u.git.johannes.schindelin@gmx.de>
2009-02-04 1:50 ` [PATCH] apply: fix access to an uninitialized mode variable, found by valgrind Johannes Schindelin
2009-02-04 7:46 ` Junio C Hamano
2009-02-04 14:36 ` Don Zickus [this message]
2009-02-04 15:31 ` Jeff King
2009-02-04 16:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204143634.GY3827@redhat.com \
--to=dzickus@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).