From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 7/8] Tests: let --valgrind imply --verbose and --tee
Date: Fri, 6 Feb 2009 15:24:26 -0500 [thread overview]
Message-ID: <20090206202425.GA19959@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0902062038420.7377@intel-tinevez-2-302>
On Fri, Feb 06, 2009 at 08:40:59PM +0100, Johannes Schindelin wrote:
> > On the other hand, I think "--verbose --tee >/dev/null" would probably
> > accomplish the same thing, so it probably isn't worth too much effort.
>
> No. Why would I want 'make test' to hide the fact from me that something
> did not work, and how it happened to fail?
Because "make test" with "--verbose" generates megabytes of output which
you don't want mailed to you by cron, and that information is already
being saved in a file by "--tee"?
-Peff
next prev parent reply other threads:[~2009-02-06 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233702893u.git.johannes.schindelin@gmx.de>
2009-02-03 23:25 ` [PATCH 1/8] Add valgrind support in test scripts Johannes Schindelin
2009-02-03 23:26 ` [PATCH 2/8] valgrind: ignore ldso and more libz errors Johannes Schindelin
2009-02-03 23:26 ` [PATCH 3/8] Valgrind support: check for more than just programming errors Johannes Schindelin
2009-02-03 23:26 ` [PATCH 4/8] test-lib.sh: optionally output to test-results/$TEST.out, too Johannes Schindelin
2009-02-03 23:26 ` [PATCH 5/8] t/Makefile: provide a 'valgrind' target Johannes Schindelin
2009-02-03 23:26 ` [PATCH 6/8] Add a script to coalesce the valgrind outputs Johannes Schindelin
2009-02-03 23:26 ` [PATCH 7/8] Tests: let --valgrind imply --verbose and --tee Johannes Schindelin
2009-02-06 19:08 ` Jeff King
2009-02-06 19:40 ` Johannes Schindelin
2009-02-06 20:24 ` Jeff King [this message]
2009-02-03 23:26 ` [PATCH 8/8] test-lib: avoid assuming that templates/ are in the GIT_EXEC_PATH Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206202425.GA19959@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).