From: Jeff King <peff@peff.net>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git@vger.kernel.org
Subject: [PATCH] fix uninitialized variable in string_expand_length
Date: Sat, 7 Feb 2009 05:37:23 -0500 [thread overview]
Message-ID: <20090207103723.GA18823@coredump.intra.peff.net> (raw)
This led to totally unpredictable results from the function. The style
matches the loop in string_expand.
Signed-off-by: Jeff King <peff@peff.net>
---
tig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tig.c b/tig.c
index 79afdb1..97794b0 100644
--- a/tig.c
+++ b/tig.c
@@ -193,7 +193,7 @@ string_expand_length(const char *line, int tabsize)
{
size_t size, pos;
- for (pos = 0; line[pos]; pos++) {
+ for (size = pos = 0; line[pos]; pos++) {
if (line[pos] == '\t' && tabsize > 0)
size += tabsize - (size % tabsize);
else
--
1.6.1.2.552.g1682c.dirty
next reply other threads:[~2009-02-07 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 10:37 Jeff King [this message]
2009-02-08 9:58 ` [PATCH] fix uninitialized variable in string_expand_length Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090207103723.GA18823@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).