git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: gitster@pobox.com
Cc: Stephan Beyer <s-beyer@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH] add -p: get rid of Git.pm warnings about unitialized values
Date: Sun, 8 Feb 2009 19:01:25 +0100	[thread overview]
Message-ID: <200902081901.44974.trast@student.ethz.ch> (raw)
In-Reply-To: <1234114839-11958-1-git-send-email-s-beyer@gmx.net>

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Stephan Beyer wrote:
> After invoking git add -p I always got the warnings:
> 
>  Use of uninitialized value $_[3] in exec at Git.pm line 1282.
>  Use of uninitialized value $args[2] in join or string at Git.pm line 1264.
[...]
> -	my $help_color_spec = $repo->config('color.interactive.help');
> +	my $help_color_spec = ($repo->config('color.interactive.help') or
> +				'red bold');

Acked-By: Thomas Rast <trast@student.ethz.ch>

Thanks for spotting this.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2009-02-08 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 17:40 [PATCH] add -p: get rid of Git.pm warnings about unitialized values Stephan Beyer
2009-02-08 18:01 ` Thomas Rast [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902081901.44974.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).