From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: repack might cause having when commit objects are missing
Date: Mon, 9 Feb 2009 10:13:03 +0100 [thread overview]
Message-ID: <20090209091303.GA1320@atjola.homenet> (raw)
In-Reply-To: <20090209022642.GA19413@atjola.homenet>
[topic fixed to resemble something sane...]
On 2009.02.09 03:26:42 +0100, Björn Steinbrink wrote:
> Up to now, I don't have a small reproduction case yet and unfortunately
> I can't make the repo with which I've seen the failure available.
Not a self-contained reproduction test, but at least it shows the
problem with a public repo. Assuming you have no refs referencing
a0325eb^
In a clone of git.git add to .git/info/grafts:
a0325eb2e982e25376e4cb89ebcac5d8d703548d 604dd0a0782b3e33bcc397c27e811ebc019c9f5a
Then:
git reflog expire --expire=0 --all
git repack -ad
rm .git/info/grafts
git repack -ad
The second repack wrecks the repo:
doener@atjola:git2 (master) $ cp /home/doener/grafts .git/info/
doener@atjola:git2 (master) $ git reflog expire --expire=0 --all
doener@atjola:git2 (master) $ git repack -ad
Counting objects: 92161, done.
Delta compression using 4 threads.
Compressing objects: 100% (23481/23481), done.
Writing objects: 100% (92161/92161), done.
Total 92161 (delta 67185), reused 92061 (delta 67092)
doener@atjola:git2 (master) $ rm .git/info/grafts
doener@atjola:git2 (master) $ git repack -ad
error: Could not read c0e2e12fa0babcc4ab28b95bc5ad4f86e139d6b4
Counting objects: 3195, done.
Delta compression using 4 threads.
Compressing objects: 100% (2245/2245), done.
Writing objects: 100% (3195/3195), done.
Total 3195 (delta 1263), reused 2418 (delta 886)
error: refs/heads/rebase does not point to a valid object!
[dozens of more broken refs]
Note how in the second repack, the walking machniery finds only 3195
objects, as opposed to more than 92k before.
I've also tried with threaded delta search disabled (pack.threads=1),
no difference.
Björn
next prev parent reply other threads:[~2009-02-09 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 2:26 "repack" when a needed commit object missing "kills" the repo Björn Steinbrink
2009-02-09 9:13 ` Björn Steinbrink [this message]
2009-02-09 9:21 ` repack might cause having when commit objects are missing Björn Steinbrink
2009-02-11 9:27 ` [PATCH] revision traversal and pack: notice and die on missing commit Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209091303.GA1320@atjola.homenet \
--to=b.steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).