git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: David Symonds <dsymonds@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Ingo Molnar <mingo@elte.hu>, Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Andreas Ericsson <ae@op5.se>,
	Jeff Garzik <jeff@garzik.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Bill Lear <rael@zopyra.com>, Jon Seymour <jon.seymour@gmail.com>
Subject: Re: Article about "git bisect run" on LWN
Date: Tue, 10 Feb 2009 07:12:31 +0100	[thread overview]
Message-ID: <200902100712.31820.chriscool@tuxfamily.org> (raw)
In-Reply-To: <ee77f5c20902091303v1d268761ufdc85e2364097d84@mail.gmail.com>

Le lundi 9 février 2009, David Symonds a écrit :
> On Tue, Feb 10, 2009 at 12:15 AM, Johannes Schindelin
>
> <Johannes.Schindelin@gmx.de> wrote:
> > I think Junio meant using '< $file' type redirection, to avoid an
> > unnecessary fork().  (Good habit, avoiding fork()s...)
>
> Yes, I usually pass filenames to grep; this time I was
> copy-and-pasting parts of the original script. But my point still
> remains: it seems it would be cleaner to do this kind of
> always-good-filtering in the test script rather than make git-bisect
> more complex.

But it's not so easy and not efficient to do this kind of filtering in the 
test script.

Maybe something cleaner could be to have "always good" and "always skipped" 
refs that are automatically used each time you bisect.

For example, "git bisect good --always" and "git bisect skip --always" could 
add refs in "refs/bisect/always/" even when you are not bisecting, and 
these refs would not be removed on reset.

But in the end, I think this does not really fix the problem. If you need 
such hacks, it means that your commit DAG is not easily bisectable. For 
example if you must skip too many commits, then too often bisection will 
not be able to point to a first bad commit because it won't be able to tell 
between many skipped commits.

That's why I think the proper fix is to have a way to bisect on a fixed up 
commit DAG where you can just get rid of old annoying bugs and of history 
parts that are not relevant.

Regards,
Christian.

  reply	other threads:[~2009-02-10  6:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05  6:47 Article about "git bisect run" on LWN Christian Couder
2009-02-05 13:34 ` Bill Lear
2009-02-05 14:13 ` Ingo Molnar
2009-02-06  2:42   ` david
2009-02-06  1:46     ` Ingo Molnar
2009-02-06  1:52       ` Ingo Molnar
2009-02-06  5:23   ` Christian Couder
2009-02-07  4:41     ` Christian Couder
2009-02-07 12:55       ` David Symonds
2009-02-07 18:09         ` Christian Couder
2009-02-07 18:16         ` Junio C Hamano
2009-02-09 12:19           ` Ingo Molnar
2009-02-09 13:15             ` Johannes Schindelin
2009-02-09 21:03               ` David Symonds
2009-02-10  6:12                 ` Christian Couder [this message]
2009-02-05 16:23 ` Jonathan Corbet
2009-02-05 20:54   ` Christian Couder
2009-02-06  2:49   ` david

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902100712.31820.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeff@garzik.org \
    --cc=jon.seymour@gmail.com \
    --cc=mingo@elte.hu \
    --cc=rael@zopyra.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).