git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Burton <markb@ordern.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	gitster@pobox.com
Subject: Re: [PATCH] builtin-branch: highlight current remote branches with an  asterisk
Date: Tue, 10 Feb 2009 11:05:46 +0000	[thread overview]
Message-ID: <20090210110546.5ead75a6@crow> (raw)
In-Reply-To: <76718490902091622y9a6d1bak5dc401858382e2ff@mail.gmail.com>

On Mon, 9 Feb 2009 19:22:50 -0500
Jay Soffian <jaysoffian@gmail.com> wrote:

> (Please don't trim cc:)
> 
> On Mon, Feb 9, 2009 at 7:03 PM, Mark Burton <markb@ordern.com> wrote:
> > I don't know if I have any scripts that rely on a single star in front of
> > the local HEAD or not (I'm sure some people must have them), but I do
> > think this new feature would be very confusing, especially when used
> > with -a.
> >
> > At the very least, make the indicator something other than a star, an @
> > or #, perhaps.
> 
> With color, it shouldn't be confusing at all as only one branch is in
> green. 

How about the colour blind git users?

> W/o color, it still seems clear to me as the remote branches
> have their remote name prefixed to them. Even if you're on a detached
> head:
> 
> * (no branch)
>   master
>   next
>   sent/branch-show-remote-HEAD
>   wip/am-usability-improvements
>   wip/push-docs
>   origin/html
>   origin/maint
>   origin/man
> * origin/master
>   origin/next
>   origin/pu
>   origin/todo
> 
> A different marker doesn't really seem like an improvement to me:
> 
> * (no branch)
>   master
>   next
>   sent/branch-show-remote-HEAD
>   wip/am-usability-improvements
>   wip/push-docs
>   origin/html
>   origin/maint
>   origin/man
> @ origin/master
>   origin/next
>   origin/pu
>   origin/todo
> 
> But I'm happy to have the community paint the shed I've constructed.
> 
> j.

You can paint a rickety old shed any colour you wish but it doesn't
make it any stronger.

Personally, I think the -> syntax is a much better idea as it is unlikely
to be confused with the existing marker and it shows the relationship
between the (remote) HEAD and remote current branch.

Cheers,

Mark

  reply	other threads:[~2009-02-10 11:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 23:32 [PATCH] builtin-branch: highlight current remote branches with an asterisk Jay Soffian
2009-02-09 23:49 ` Johannes Schindelin
2009-02-10  0:03   ` Mark Burton
2009-02-10  0:22     ` Jay Soffian
2009-02-10 11:05       ` Mark Burton [this message]
2009-02-10  0:24     ` Junio C Hamano
2009-02-10  7:59       ` Santi Béjar
2009-02-10  0:10   ` Jay Soffian
2009-02-10  7:52 ` Björn Steinbrink
2009-02-10  8:02   ` Santi Béjar
2009-02-10  8:24     ` Björn Steinbrink
2009-02-10 11:19   ` Jeff King
2009-02-10 11:50     ` Björn Steinbrink
2009-02-10 11:59       ` Jeff King
2009-02-10 12:23         ` Björn Steinbrink
2009-02-10 13:04           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090210110546.5ead75a6@crow \
    --to=markb@ordern.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jaysoffian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).