From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: [PATCH JGIT] Deal with the signed-off in the commit text dialog
Date: Wed, 11 Feb 2009 01:16:35 +0100 [thread overview]
Message-ID: <200902110116.36172.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <49917944.6030309@gmail.com>
tisdag 10 februari 2009 13:55:32 skrev Yann Simon:
> The user can see and edit the signed-off in the commit dialog
> before committing.
>
> Updating the committer updates the signed-off.
>
> For new lines in the commit dialog, use Text.DELIMITER for
> plateform neutrality.
Spell "platform"
These is two unrelated changes. I don't deeply about the switch, but
I do want the line end handling so we don't get double spaced messages.
The toggle swithch will happily double the SOB-line. It assumes it is
the last line. Isn't that too strict, though it is the common idiom, but
we also have other types of X-by-lines that we often place below
the SOB line.
Signed-off-by: hacker
Signed-off-by: pschorff
Acked-by: bar
-- robin
next prev parent reply other threads:[~2009-02-11 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 12:55 [PATCH JGIT] Deal with the signed-off in the commit text dialog Yann Simon
2009-02-11 0:16 ` Robin Rosenberg [this message]
2009-02-11 17:02 ` [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog) Yann Simon
2009-02-11 19:40 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902110116.36172.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).