From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Deskin Miller <deskinm@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2 5/6] gitweb: last-modified time should be commiter, not author
Date: Wed, 11 Feb 2009 10:18:38 +0100 [thread overview]
Message-ID: <200902111018.39699.jnareb@gmail.com> (raw)
In-Reply-To: <cb7bb73a0902110102k5b7e5a21vd7d0932c6b6ba20e@mail.gmail.com>
On Wed, 11 Feb 2009, Giuseppe Bilotta wrote:
> On Wed, Feb 11, 2009 at 4:10 AM, Deskin Miller <deskinm@gmail.com> wrote:
>> On Fri, Feb 6, 2009 at 18:00, Giuseppe Bilotta
>> <giuseppe.bilotta@gmail.com> wrote:
>>>
>>> The real question is: _how_ do you get the (branch) update time?
>>>
>>
>> Sorry the topic's cold, but...
>>
>> git reflog?
>>
>> Seems like one could find the oldest time the commit appears in the
>> reflog, for the branch one is interested in. You can use the commit
>> time to limit the search through the reflog, but there would be clock
>> skew concerns.
>
> Bingo! Thanks a lot
>
> oblomov@rbot ~ $ GIT_DIR=/var/git/rbot.git/ git reflog show
> --since="two days ago" master | cat
> 7324b32... master@{0}: push
> e2dc08d... master@{1}: push
> oblomov@rbot ~ $ GIT_DIR=/var/git/rbot.git/ git reflog show
> --since="yesterday" master | cat
> oblomov@rbot ~ $
>
> I'll try to work it in the next review for this patchset.
Assuming that you have reflog enabled (yes, it is default now)...
So you would have to provide fallback in the case there is no reflog.
BTW. "git reflog" is porcelain; it would be better to parse reflog
directly, I think.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-02-11 9:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 11:50 [PATCHv2 0/6] gitweb: feed metadata enhancements Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 1/6] gitweb: channel image in rss feed Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 2/6] gitweb: feed generator metadata Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 3/6] gitweb: rss feed managingEditor Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 4/6] gitweb: rss channel date Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 5/6] gitweb: last-modified time should be commiter, not author Giuseppe Bilotta
2009-01-26 11:50 ` [PATCHv2 6/6] gitweb: check if-modified-since for feeds Giuseppe Bilotta
2009-02-05 2:03 ` Jakub Narebski
2009-02-06 11:19 ` Giuseppe Bilotta
2009-02-04 23:38 ` [PATCHv2 5/6] gitweb: last-modified time should be commiter, not author Jakub Narebski
2009-02-06 11:14 ` Giuseppe Bilotta
2009-02-06 21:12 ` Jakub Narebski
2009-02-06 23:00 ` Giuseppe Bilotta
2009-02-11 3:10 ` Deskin Miller
2009-02-11 9:02 ` Giuseppe Bilotta
2009-02-11 9:18 ` Jakub Narebski [this message]
2009-02-11 9:54 ` Giuseppe Bilotta
2009-02-12 4:50 ` Deskin Miller
2009-02-12 9:07 ` Jakub Narebski
2009-02-12 9:52 ` Giuseppe Bilotta
2009-02-12 10:11 ` Jakub Narebski
2009-02-12 11:23 ` Giuseppe Bilotta
2009-02-04 23:24 ` [PATCHv2 4/6] gitweb: rss channel date Jakub Narebski
2009-02-06 11:10 ` Giuseppe Bilotta
2009-02-04 23:19 ` [PATCHv2 3/6] gitweb: rss feed managingEditor Jakub Narebski
2009-02-06 11:03 ` Giuseppe Bilotta
2009-02-04 23:15 ` [PATCHv2 2/6] gitweb: feed generator metadata Jakub Narebski
2009-02-06 11:01 ` Giuseppe Bilotta
2009-02-06 11:21 ` Jakub Narebski
2009-02-04 22:56 ` [PATCHv2 1/6] gitweb: channel image in rss feed Jakub Narebski
2009-02-06 10:55 ` Giuseppe Bilotta
2009-01-28 20:58 ` [PATCHv2 0/6] gitweb: feed metadata enhancements Junio C Hamano
2009-01-28 21:48 ` Jakub Narebski
2009-01-28 21:57 ` Giuseppe Bilotta
2009-01-28 22:03 ` Junio C Hamano
2009-02-06 22:42 ` Jakub Narebski
2009-02-07 0:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902111018.39699.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=deskinm@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).