From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/RFH] Fun things with git-notes, or: patch tracking backwards
Date: Wed, 11 Feb 2009 23:52:36 +0100 [thread overview]
Message-ID: <200902112352.40955.trast@student.ethz.ch> (raw)
In-Reply-To: <7vprhpkgzk.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
> > Right now it's just the patch-id. Maybe filtering (author,subject)
> > and then picking the one that is the most similar could work.
>
> Yeah, I actually was thinking about matching the (date, author) tuple and
> nothing else, as it is unlikely you would have dups.
Thanks, good idea. I changed the code to parse the required data, and
we're now up to 1502 annotations.
Unfortunately I noticed there's a bug in the mail input stage:
Python's mailbox module assumes any '^From ' line starts a new mail,
while gmane apparently uses a slightly different format based on the
double newlines too (and they always have the same 'From
news@gmane.org Tue Mar 04 03:33:20 2003' separator too), and doesn't
quote '^From ' in the bodies. So any mail containing such body lines
got chopped down in the middle, and any patches contained in them
won't apply because of the missing headers.
A quick perl run shows that there are 26 mails affected among the
89000+ mails that I've (again) imported. The fix should be easy, but
I'm already short on sleep.
> I find the "Extra-Notes:" tag a bit too loud, but I am probably a minority
> who thinks everything but the Message-ID can be dropped, so please don't
> take it as a feature request ;-)
I refactored the final formatting stage a bit to let it do several
notes trees, and you can now take your pick:
git://repo.or.cz/trackgit.git notes/full
git://repo.or.cz/trackgit.git notes/terse
The latter only has 'Message-Id' and 'Archived-At'.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-11 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 14:08 [RFC/RFH] Fun things with git-notes, or: patch tracking backwards Thomas Rast
2009-02-09 16:19 ` SZEDER Gábor
2009-02-09 16:29 ` Thomas Rast
2009-02-09 17:49 ` tool and worktree Giuseppe Bilotta
2009-02-10 22:42 ` [RFC/RFH] Fun things with git-notes, or: patch tracking backwards Thomas Rast
2009-02-10 22:52 ` Junio C Hamano
2009-02-10 22:59 ` Junio C Hamano
2009-02-10 23:12 ` Thomas Rast
2009-02-10 23:30 ` Junio C Hamano
2009-02-11 22:52 ` Thomas Rast [this message]
2009-02-11 22:58 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902112352.40955.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).