From: Thomas Rast <trast@student.ethz.ch>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Ryan Anderson <ryan@michonline.com>,
gitster@pobox.com
Subject: Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message
Date: Sat, 14 Feb 2009 00:32:15 +0100 [thread overview]
Message-ID: <200902140032.19922.trast@student.ethz.ch> (raw)
In-Reply-To: <1234566313-36478-1-git-send-email-jaysoffian@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Jay Soffian wrote:
> - if (/^(Signed-off-by|Cc): (.*)$/i) {
> - next if ($suppress_cc{'sob'});
[...]
> + if (/^(Signed-off-by|Cc): (.*)$/i) {
> + next if ($suppress_cc{'sob'});
Doesn't this actually look like a long-standing send-email bug? Since
6564828 (git-send-email: Generalize auto-cc recipient mechanism.,
2007-12-25) they should go in separate categories, but the above lines
were just translated from the old $signed_off_cc setting. It seems
they should distinguish between SOB and Cc.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-13 23:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 23:05 [PATCH] send-email: handle multiple Cc addresses when reading mbox message Jay Soffian
2009-02-13 23:32 ` Thomas Rast [this message]
2009-02-13 23:39 ` Jay Soffian
2009-02-13 23:44 ` Jay Soffian
2009-02-14 3:51 ` Jay Soffian
2009-02-14 16:57 ` Thomas Rast
2009-02-14 3:51 ` [PATCH 1/3] send-email: correct logic error with --suppress-cc=cc Jay Soffian
2009-02-14 6:21 ` [PATCH 1/3 v2] " Jay Soffian
2009-02-14 6:52 ` Junio C Hamano
2009-02-14 7:15 ` Jay Soffian
2009-02-14 7:35 ` Junio C Hamano
2009-02-14 3:51 ` [PATCH 2/3] send-email: don't call unquote_rfc2047 unnecessarily Jay Soffian
2009-02-14 5:50 ` Jay Soffian
2009-02-14 3:51 ` [PATCH 3/3] send-email: --suppress-cc improvements Jay Soffian
2009-02-14 5:37 ` [PATCH 3/3 v2] " Jay Soffian
2009-02-14 6:36 ` Junio C Hamano
2009-02-14 17:06 ` [PATCH v3] " Thomas Rast
2009-02-14 17:06 ` [Interdiff " Thomas Rast
2009-02-14 22:21 ` [PATCH " Thomas Rast
2009-02-15 10:47 ` Junio C Hamano
2009-02-14 0:31 ` [PATCH] send-email: handle multiple Cc addresses when reading mbox message Jeff King
2009-02-14 0:42 ` Jay Soffian
2009-02-14 3:37 ` Jeff King
2009-02-14 8:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902140032.19922.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=ryan@michonline.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).