From: Jakub Narebski <jnareb@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [RFH] How to review patches: Documentation/ReviewingPatches?
Date: Sun, 15 Feb 2009 02:14:22 +0100 [thread overview]
Message-ID: <200902150214.24146.jnareb@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902130055370.26370@racer>
On Fri, 13 Feb 2009, Johannes Schindelin wrote:
> There is another reason why I do not want any ReviewingPatches: reviewing
> is already such a tedious process; let's not make it harder by forcing a
> potential reviewer to sift through a document (the same could be said
> about SubmittingPatches; IMHO it just repeats what common sense would do
> anyway when imitating existing code).
>
> I'd rather suggest to patch submitters to make such a good case that all
> the world is interested in their patch, throwing a lot of eyeballs (AKA
> review) at it.
Well, I thought of ReviewingPatches less as of listing set of rules to
follow, as in the case of SubmittingPatches (because there output is
processed by tools, and preserved), but rather as set of guidelines and
hints. Something like "rules" of programming :-).
--
Jakub Narebski
Poland
prev parent reply other threads:[~2009-02-15 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 23:45 [RFH] How to review patches: Documentation/ReviewingPatches? Jakub Narebski
2009-02-13 0:08 ` Johannes Schindelin
2009-02-13 7:54 ` Marius Storm-Olsen
2009-02-13 8:44 ` Junio C Hamano
2009-02-13 11:05 ` Johannes Schindelin
2009-02-15 1:14 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902150214.24146.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).