From: Greg KH <greg@kroah.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Thomas Rast <trast@student.ethz.ch>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/3] send-email: handle multiple Cc addresses when reading mbox message
Date: Sat, 14 Feb 2009 21:07:31 -0800 [thread overview]
Message-ID: <20090215050731.GA32067@kroah.com> (raw)
In-Reply-To: <1234672335-54321-3-git-send-email-jaysoffian@gmail.com>
On Sat, Feb 14, 2009 at 11:32:14PM -0500, Jay Soffian wrote:
> When git format-patch is given multiple --cc arguments, it generates a
> Cc header that looks like:
>
> Cc: first@example.com,
> second@example.com,
> third@example.com
>
> Before this commit, send-email was unable to handle such a message as it
> did not handle folded header lines, nor multiple recipients in a Cc
> line.
>
> This patch:
>
> - Unfolds header lines by pre-processing the header before extracting
> any of its fields.
>
> - Handles Cc lines with multiple recipients.
>
> - Adds use of Mail::Address if available for splitting Cc line and
> the "Who should the emails be sent to?" prompt", with fall back to
> existing split_addrs() function.
YES!!!
I was just trying to fix this in the latest version, as it couldn't
handle mbox files well at all (vger.kernel.org spit the output back at
me quite nastily when I tried it.)
Thanks for these fixes, I personally really appreciate it, and need
them.
greg k-h
prev parent reply other threads:[~2009-02-15 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 4:32 [PATCH v2 0/3] send-email Jay Soffian
2009-02-15 4:32 ` [PATCH v2 1/3] send-email: allow send-email to run outside a repo Jay Soffian
2009-02-15 4:32 ` [PATCH v2 2/3] send-email: handle multiple Cc addresses when reading mbox message Jay Soffian
2009-02-15 4:32 ` [PATCH v2 3/3] send-email: --suppress-cc improvements Jay Soffian
2009-02-15 5:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215050731.GA32067@kroah.com \
--to=greg@kroah.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).