* [PATCH] git-svn: Fix for rewriteRoot URL containing username.
@ 2009-02-11 23:14 Dévai Tamás
2009-02-16 0:55 ` Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Dévai Tamás @ 2009-02-11 23:14 UTC (permalink / raw)
To: git, gitster; +Cc: Dévai Tamás
If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option
(or by the --rewrite-root option to 'git svn init') contains a username
(such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find
the repository URL, because the URL contained in the commit message does have
the username removed.
Signed-off-by: Dévai Tamás <devait@mailbox.sk>
---
git-svn.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 001a1d8..83cb36f 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional
my $prefix = '';
if ($rwr) {
$z = $rwr;
+ remove_username($z);
} elsif (defined $svm) {
$z = $svm->{source};
$prefix = $svm->{replace};
--
1.6.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] git-svn: Fix for rewriteRoot URL containing username.
2009-02-11 23:14 [PATCH] git-svn: Fix for rewriteRoot URL containing username Dévai Tamás
@ 2009-02-16 0:55 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2009-02-16 0:55 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Dévai Tamás
Dévai Tamás <devait@mailbox.sk> wrote:
> If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option
> (or by the --rewrite-root option to 'git svn init') contains a username
> (such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find
> the repository URL, because the URL contained in the commit message does have
> the username removed.
>
> Signed-off-by: Dévai Tamás <devait@mailbox.sk>
Thanks Dévai,
Acked-by: Eric Wong <normalperson@yhbt.net>
> ---
> git-svn.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 001a1d8..83cb36f 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional
> my $prefix = '';
> if ($rwr) {
> $z = $rwr;
> + remove_username($z);
> } elsif (defined $svm) {
> $z = $svm->{source};
> $prefix = $svm->{replace};
> --
> 1.6.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-16 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-11 23:14 [PATCH] git-svn: Fix for rewriteRoot URL containing username Dévai Tamás
2009-02-16 0:55 ` Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).