From: Thomas Rast <trast@student.ethz.ch>
To: Gerfried Fuchs <rhonda@deb.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-svn: Allow using arguments to the editor.
Date: Wed, 18 Feb 2009 15:15:53 +0100 [thread overview]
Message-ID: <200902181515.59625.trast@student.ethz.ch> (raw)
In-Reply-To: <1234964869-11159-1-git-send-email-rhonda@deb.at>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
Gerfried Fuchs wrote:
> When setting the EDITOR or VISUAL environment variable, one might want
> to hand over arguments (like e.g. for not backgrounding a GUI editor but
> waiting for it to finish. This patch enables that posibility, before it
> did look for a program with the content of the variable, including the
> space as filename part. The change is in sync with regular behavior with
> various other tools, git itself included.
[...]
> + my (@editor) = split /\s+/, $editor;
This doesn't handle quoted spaces and such. launch_editor() seems to
pass the $EDITOR through 'sh -c' if there are any special characters
inside, wouldn't that be appropriate for git-svn too?
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-18 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 13:47 [PATCH] git-svn: Allow using arguments to the editor Gerfried Fuchs
2009-02-18 14:15 ` Thomas Rast [this message]
2009-02-18 14:48 ` Gerfried Fuchs
2009-02-18 15:43 ` Thomas Rast
2009-02-19 8:10 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902181515.59625.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=rhonda@deb.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).