From: "Shawn O. Pearce" <spearce@spearce.org>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line
Date: Wed, 18 Feb 2009 09:01:16 -0800 [thread overview]
Message-ID: <20090218170116.GC22848@spearce.org> (raw)
In-Reply-To: <4993DBF0.8070901@gmail.com>
Yann Simon <yann.simon.fr@gmail.com> wrote:
> The previous implementation made the assumption that
> the Signed-off-by is always on the last line.
>
> Correct this assumption and deal with Signed-off-by everywhere in
> the commit message.
>
> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
> ---
> .../egit/ui/internal/dialogs/CommitDialog.java | 65
> ++++++++++++--------
> 1 files changed, 40 insertions(+), 25 deletions(-)
This patch is whitespace damaged and can't be applied by machine.
> diff --git
> a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
> b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
> index bbe7193..403d69d 100644
> ---
> a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
> +++
> b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
--
Shawn.
next prev parent reply other threads:[~2009-02-18 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 8:21 [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line Yann Simon
2009-02-18 17:01 ` Shawn O. Pearce [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-19 9:20 Yann Simon
2009-02-19 17:28 ` Robin Rosenberg
2009-02-19 17:53 ` Sverre Rabbelier
2009-02-20 7:48 ` Yann Simon
2009-02-20 8:09 Yann Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218170116.GC22848@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).