From: "Shawn O. Pearce" <spearce@spearce.org>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] git-gui: properly check for a bare repo
Date: Wed, 18 Feb 2009 13:53:12 -0800 [thread overview]
Message-ID: <20090218215312.GO22848@spearce.org> (raw)
In-Reply-To: <cb7bb73a0902181347k6ae479b4v84e2ea8a9f6639dc@mail.gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 6:16 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> >
> > This doesn't work as you expect. Its a chicken-and-egg problem.
> > We haven't read the config yet because we aren't sure that the
> > $_gitdir really is a git directory. Consequently, core.bare is
> > always false.
>
> Isn't the config loaded on line 1053?
No, that line is only run if there is no git repository here and
we are opening the repository selection wizard. The load_config
is to pull in the user's ~/.gitconfig.
> Better ways to work around the issue?
Break down and run the fork command here. We already ran two
git-rev-parse calls at 1049,1050. One more here during startup
isn't going to kill the world.
The only problem is, you need to watch out for the git version.
AFAIK git-gui still runs on git 1.5.0. Any option added since should
be used only if its known to exist, or if there is a fallback that
works almost as good.
Or, we need to up our minimum version around line 842, and in the
messages above in 756, 787, 789, 791, and their translations...
--
Shawn.
next prev parent reply other threads:[~2009-02-18 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 2:00 [PATCH 0/3] git-gui: generic and robust worktree/gitdir support Giuseppe Bilotta
2009-02-09 2:00 ` [PATCH 1/3] git-gui: properly check for a bare repo Giuseppe Bilotta
2009-02-18 17:16 ` Shawn O. Pearce
2009-02-18 21:47 ` Giuseppe Bilotta
2009-02-18 21:53 ` Shawn O. Pearce [this message]
2009-02-09 2:00 ` [PATCH 2/3] git-gui: use the actual worktree Giuseppe Bilotta
2009-02-18 17:22 ` Shawn O. Pearce
2009-02-09 2:00 ` [PATCH 3/3] git-gui: define correct GIT_DIR for gitk Giuseppe Bilotta
2009-02-18 17:22 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218215312.GO22848@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).