From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
John Tapsell <johnflux@gmail.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] rev-list: estimate number of bisection step left
Date: Thu, 19 Feb 2009 06:32:49 +0100 [thread overview]
Message-ID: <200902190632.50156.chriscool@tuxfamily.org> (raw)
In-Reply-To: <200902190616.18747.chriscool@tuxfamily.org>
Le jeudi 19 février 2009, Christian Couder a écrit :
>
> But on Linux, log2 and exp2 are defined in "math.h" and available with:
>
> _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE; or cc -std=c99
>
> and we must link with -lm, but I don't know about the other platforms.
>
> So I don't know what to do about them. Please advise.
What I mean is that log2 is just something like:
int log2 = 0;
for (; n > 1; n >>= 1)
log2++;
and exp2 is just "1 << n", so I wonder if it's really necessary to add a lot
of stuff in the Makefile for these 2 really short functions.
Regards,
Christian.
next prev parent reply other threads:[~2009-02-19 5:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 5:09 [PATCH] rev-list: estimate number of bisection step left Christian Couder
2009-02-17 7:28 ` Junio C Hamano
2009-02-19 5:16 ` Christian Couder
2009-02-19 5:26 ` Christian Couder
2009-02-19 5:32 ` Christian Couder [this message]
2009-02-19 6:02 ` John Tapsell
2009-02-19 6:49 ` Christian Couder
2009-02-17 14:44 ` Johannes Schindelin
2009-02-17 15:11 ` John Tapsell
2009-02-17 15:31 ` Johannes Schindelin
2009-02-17 15:36 ` John Tapsell
2009-02-17 15:39 ` Johannes Schindelin
2009-02-17 15:39 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902190632.50156.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
--cc=mingo@elte.hu \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).