From: Thomas Rast <trast@student.ethz.ch>
To: John Tapsell <johnflux@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 5/6] Change output "error: " to "Error: " etc
Date: Thu, 19 Feb 2009 09:14:57 +0100 [thread overview]
Message-ID: <200902190915.15227.trast@student.ethz.ch> (raw)
In-Reply-To: <200902190736.49161.johnflux@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]
John Tapsell wrote:
> All the error messages starting "Error: " begin with a captial E, except
> in one place. This commit fixes this, making the output look more
> consistent. At the moment a failed push, say, looks like:
>
> Error: cannot lock existing info/refs
> error: failed to push some refs to 'some repository'
[...]
> - report("fatal: ", err, params);
> + report("Fatal: ", err, params);
A quick grep says this is going to break the tests:
t/t1400-update-ref.sh: test "warning: Log for '\'master\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: echo test "warning: Log for '\'master\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log for '\''master'\'' only goes back to $ed." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log .git/logs/'"$m has gap after $gd"'." = "$(cat e)"'
t/t1400-update-ref.sh: test "warning: Log .git/logs/'"$m unexpectedly ended on $ld"'." = "$(cat e)"'
t/t4012-diff-binary.sh: detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
t/t4012-diff-binary.sh: detected=`expr "$detected" : "fatal.*at line \\([0-9]*\\)\$"` &&
t/t4018-diff-funcname.sh: grep "fatal" > /dev/null )
t/t4018-diff-funcname.sh: grep "fatal: Last expression must not be negated:"
t/t5400-send-pack.sh: grep "warning: to refuse deleting" child/errs &&
t/t5510-fetch.sh: grep "fatal: '\''a\\\\!'\''b'\''" result
t/t5516-fetch-push.sh: grep "warning: updating the current branch" stderr
t/t5516-fetch-push.sh: ! grep "warning: updating the current branch" stderr
t/t5516-fetch-push.sh: ! grep "warning: updating the current branch" stderr
t/t6300-for-each-ref.sh: \"error: more than one quoting style\"*) : happy;;
t/test-lib.sh: say_color error "error: $*"
That being said, I'm not sure we can change this at all since it's the
plumbing way of reporting errors/warnings.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-19 8:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 7:36 [PATCH 5/6] Change output "error: " to "Error: " etc John Tapsell
2009-02-19 8:14 ` Thomas Rast [this message]
2009-02-19 8:17 ` Jeff King
2009-02-19 12:07 ` [PATCH] http-push: using error() and warning() as appropriate Miklos Vajna
2009-02-19 12:21 ` Jeff King
2009-02-19 12:52 ` [PATCH 0/8] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-02-19 12:53 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-20 3:02 ` Jeff King
2009-02-20 6:11 ` Junio C Hamano
2009-03-22 11:36 ` Miklos Vajna
2009-03-22 21:58 ` Junio C Hamano
2009-03-24 1:09 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-03-24 1:09 ` [PATCH 1/9] http-push: using error() and warning() as appropriate Miklos Vajna
2009-03-24 1:09 ` [PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-03-24 1:09 ` [PATCH 3/9] builtin-checkout: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 4/9] builtin-fetch-pack: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 5/9] builtin-init-db: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 6/9] builtin-rm: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 7/9] builtin-show-branch: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 8/9] builtin-show-ref: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 9/9] refs: " Miklos Vajna
2009-03-24 1:17 ` Erik Faye-Lund
2009-03-24 1:23 ` Miklos Vajna
2009-03-24 1:28 ` Erik Faye-Lund
2009-03-24 1:25 ` [PATCH 2/9] builtin-apply: " Erik Faye-Lund
2009-03-24 7:35 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Jeff King
2009-03-24 8:01 ` Junio C Hamano
2009-02-20 9:41 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-19 12:53 ` [PATCH 2/8] builtin-checkout: " Miklos Vajna
2009-02-19 12:53 ` [PATCH 3/8] builtin-fetch-pack: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 4/8] builtin-init-db: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 5/8] builtin-rm: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 6/8] builtin-show-branch: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 7/8] builtin-show-ref: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 8/8] refs: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902190915.15227.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).