git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Pieter de Bie <pieter@frim.nl>
Cc: John Tapsell <johnflux@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 6/6] Mention to the user that they can reorder commits
Date: Thu, 19 Feb 2009 11:16:38 +0100	[thread overview]
Message-ID: <20090219101638.GA20707@neumann> (raw)
In-Reply-To: <53F7BA4C-6F63-4993-A959-E67E4FB4F456@frim.nl>

On Thu, Feb 19, 2009 at 09:13:49AM +0000, Pieter de Bie wrote:
>
> On 19 feb 2009, at 07:37, John Tapsell wrote:
>
>> Signed-off-by: John Tapsell <johnflux@gmail.com>
>> ---
>
> Yes, this has been raised many times in #git now, so it makes
> sense to include it.

A similar idea came around last week, and in turn Dscho explained why
such a change is not a good idea.  I think he is fully right here.


<alpine.DEB.1.00.0902092228470.10279@pacific.mpi-cbg.de>
http://article.gmane.org/gmane.comp.version-control.git/109136

  On Mon, Feb 09, 2009 at 10:31:56PM +0100, Johannes Schindelin wrote:
  > If we start along those lines, we also have to add documentation how
  > to
  > 
  > - split commit,
  > 
  > - change authorship of commits,
  > 
  > - deal with commits where --cherry-pick did not detect that they were 
  >   applied already,
  > 
  > - deal with merge commits, and
  > 
  > - possibly a lot more.
  > 
  > I do not think that this is a good way to spend valuable screen
  > estate; I 
  > think that is what the man page should cover.
  > 
  > I only made an exception for the deletion of lines, as people were 
  > actively burnt.  Yes, they should have read the man page.  But the 
  > consequences of not doing so were bad.


Regards,
Gábor

  reply	other threads:[~2009-02-19 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19  7:37 [PATCH 6/6] Mention to the user that they can reorder commits John Tapsell
2009-02-19  9:13 ` Pieter de Bie
2009-02-19 10:16   ` SZEDER Gábor [this message]
2009-02-19 10:24     ` John Tapsell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090219101638.GA20707@neumann \
    --to=szeder@ira.uka.de \
    --cc=git@vger.kernel.org \
    --cc=johnflux@gmail.com \
    --cc=pieter@frim.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).