From: Jeff King <peff@peff.net>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Junio C Hamano <gitster@pobox.com>,
John Tapsell <johnflux@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ")
Date: Thu, 19 Feb 2009 22:02:45 -0500 [thread overview]
Message-ID: <20090220030245.GC22419@coredump.intra.peff.net> (raw)
In-Reply-To: <4f61642d10063adbff86094e91b1b6e90efabe8e.1235047192.git.vmiklos@frugalware.org>
On Thu, Feb 19, 2009 at 01:53:10PM +0100, Miklos Vajna wrote:
> @@ -2932,8 +2932,7 @@ static int write_out_one_reject(struct patch *patch)
> cnt = strlen(patch->new_name);
> if (ARRAY_SIZE(namebuf) <= cnt + 5) {
> cnt = ARRAY_SIZE(namebuf) - 5;
> - fprintf(stderr,
> - "warning: truncating .rej filename to %.*s.rej",
> + warning("truncating .rej filename to %.*s.rej",
> cnt - 1, patch->new_name);
> }
Hmm. This hunk is actually changing behavior, as the original didn't
have a newline. It looks like a bug in the original, though.
Other than that, these all look pretty straightforward. Probably the
shell scripts should be switched to match, too. But it would be nice to
hear from Junio first that this cleanup is even desired (so you don't
waste time).
-Peff
next prev parent reply other threads:[~2009-02-20 3:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 7:36 [PATCH 5/6] Change output "error: " to "Error: " etc John Tapsell
2009-02-19 8:14 ` Thomas Rast
2009-02-19 8:17 ` Jeff King
2009-02-19 12:07 ` [PATCH] http-push: using error() and warning() as appropriate Miklos Vajna
2009-02-19 12:21 ` Jeff King
2009-02-19 12:52 ` [PATCH 0/8] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-02-19 12:53 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-20 3:02 ` Jeff King [this message]
2009-02-20 6:11 ` Junio C Hamano
2009-03-22 11:36 ` Miklos Vajna
2009-03-22 21:58 ` Junio C Hamano
2009-03-24 1:09 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-03-24 1:09 ` [PATCH 1/9] http-push: using error() and warning() as appropriate Miklos Vajna
2009-03-24 1:09 ` [PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-03-24 1:09 ` [PATCH 3/9] builtin-checkout: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 4/9] builtin-fetch-pack: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 5/9] builtin-init-db: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 6/9] builtin-rm: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 7/9] builtin-show-branch: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 8/9] builtin-show-ref: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 9/9] refs: " Miklos Vajna
2009-03-24 1:17 ` Erik Faye-Lund
2009-03-24 1:23 ` Miklos Vajna
2009-03-24 1:28 ` Erik Faye-Lund
2009-03-24 1:25 ` [PATCH 2/9] builtin-apply: " Erik Faye-Lund
2009-03-24 7:35 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Jeff King
2009-03-24 8:01 ` Junio C Hamano
2009-02-20 9:41 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-19 12:53 ` [PATCH 2/8] builtin-checkout: " Miklos Vajna
2009-02-19 12:53 ` [PATCH 3/8] builtin-fetch-pack: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 4/8] builtin-init-db: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 5/8] builtin-rm: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 6/8] builtin-show-branch: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 7/8] builtin-show-ref: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 8/8] refs: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220030245.GC22419@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).