git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com,
	Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [HALF A PATCH] Teach the '--exclude' option to 'diff --no-index'
Date: Fri, 20 Feb 2009 09:53:31 -0500	[thread overview]
Message-ID: <20090220145331.GA3515@coredump.intra.peff.net> (raw)
In-Reply-To: <cf17659db8a4f7fe9d878984effcdd8d6417c862.1235138849u.git.johannes.schindelin@gmx.de>

On Fri, Feb 20, 2009 at 03:12:28PM +0100, Johannes Schindelin wrote:

> 	Michael wrote:
> 
> 	> I can't think offhand of a more portable tool that could replace 
> 	> "diff -r -x" here (suggestions, anyone?).
> 
> 	Maybe something like this?

Great. Using "git diff" was my first thought, too.

> 	Note: before it can be included in git.git, documentation and 
> 	tests have to be added; also, it might be a good idea to extend it 
> 	to the "non-no-index" case (maybe I can beat Peff in the number of 
> 	double negations one day...)

Maybe a config option "diff.denyNonIndexExclude = false"? *ducks*

But more seriously, how would a user expect this to interact with
.gitignore? I know gitignore is about ignoring untracked files, but I
can't help but feel the two have something in common. But maybe not. I'm
sick today and my brain is not working very well.

-Peff

  reply	other threads:[~2009-02-20 14:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  5:18 [PATCH 0/4] Add more tests of cvsimport Michael Haggerty
2009-02-20  5:18 ` [PATCH 1/4] Start a library for cvsimport-related tests Michael Haggerty
2009-02-20  5:18   ` [PATCH 2/4] Use CVS's -f option if available (ignore user's ~/.cvsrc file) Michael Haggerty
2009-02-20  5:18     ` [PATCH 3/4] Test contents of entire cvsimported "master" tree contents Michael Haggerty
2009-02-20  5:18       ` [PATCH 4/4] Add some tests of git-cvsimport's handling of vendor branches Michael Haggerty
2009-02-20  6:25 ` [PATCH 0/4] Add more tests of cvsimport Jeff King
2009-02-20  7:40   ` Junio C Hamano
2009-02-20 11:24     ` Michael Haggerty
2009-02-20 14:12       ` [HALF A PATCH] Teach the '--exclude' option to 'diff --no-index' Johannes Schindelin
2009-02-20 14:53         ` Jeff King [this message]
2009-02-20 15:03           ` Johannes Schindelin
2009-02-20 18:34             ` Jakub Narebski
2009-02-20 20:04               ` Johannes Schindelin
2009-02-20 16:34         ` Junio C Hamano
2009-02-24 16:15           ` Johannes Schindelin
2009-02-24 17:01             ` Junio C Hamano
2009-02-20 10:21   ` [PATCH 0/4] Add more tests of cvsimport Michael Haggerty
2009-02-20 15:00     ` Jeff King
2009-02-20 21:26     ` Samuel Lucas Vaz de Mello
2009-02-21  6:32       ` Michael Haggerty
2009-02-20  8:27 ` Ferry Huberts (Pelagic)
2009-02-21 13:05   ` Michael Haggerty
2009-02-21 13:19     ` Ferry Huberts (Pelagic)
2009-02-22 16:49     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220145331.GA3515@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).