git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: Note file formats send-email accepts
@ 2009-02-19  3:51 Todd Zullinger
  2009-02-21  0:04 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Todd Zullinger @ 2009-02-19  3:51 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git


Signed-off-by: Todd Zullinger <tmz@pobox.com>
---

These formats are noted in the git-send-email.perl script, but not
mentioned in the documentation anywhere.  I debated adding a note that
the mbox format was generally preferred, but I wasn't sure if that was
important or appropriate.  I felt that I had bloated the Description
section enough already. :)

I hope that I got the aciidoc punctuation correct.  When to use ''
versus `` wasn't entirely clear.  So I made like a chamealeon and
tried to emulate what was nearby.

This was spurred by a bug report against the Fedora git packages:

    https://bugzilla.redhat.com/486103

 Documentation/git-send-email.txt |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index ff4aeff..66bf3b2 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -19,6 +19,19 @@ The header of the email is configurable by command line options.  If not
 specified on the command line, the user will be prompted with a ReadLine
 enabled interface to provide the necessary information.

+There are two formats accepted for patch files:
+
+1. mbox format files
++
+This is what linkgit:git-format-patch[1] generates.  Most headers and MIME
+formatting are ignored.
+
+2. The original format used by Greg Kroah-Hartman's 'send_lots_of_email.pl'
+script
++
+This format expects the first line of the file to contain the "Cc:" value
+and the "Subject:" of the message as the second line.
+

 OPTIONS
 -------
-- 
1.6.1.3

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Most people would sooner die than think; in fact, they do so.
    -- Bertrand Russell (1872-1970)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation: Note file formats send-email accepts
  2009-02-19  3:51 [PATCH] Documentation: Note file formats send-email accepts Todd Zullinger
@ 2009-02-21  0:04 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2009-02-21  0:04 UTC (permalink / raw)
  To: Todd Zullinger; +Cc: Junio C Hamano, git

On Wed, Feb 18, 2009 at 10:51:06PM -0500, Todd Zullinger wrote:
> +There are two formats accepted for patch files:
> +
> +1. mbox format files
> ++
> +This is what linkgit:git-format-patch[1] generates.  Most headers and MIME
> +formatting are ignored.
> +
> +2. The original format used by Greg Kroah-Hartman's 'send_lots_of_email.pl'
> +script

You're kidding me, right?  I really don't believe anyone uses any
patches in that format, I haven't used that script in so long I just
noticed that I didn't even have a copy of it anywhere.

So if for some reason you are trying to be backwards compatible to my
old code, don't do it on my behalf.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-21  0:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-19  3:51 [PATCH] Documentation: Note file formats send-email accepts Todd Zullinger
2009-02-21  0:04 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).