From: Johannes Sixt <j6t@kdbg.org>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v4] Test fsck a bit harder
Date: Sat, 21 Feb 2009 20:21:37 +0100 [thread overview]
Message-ID: <200902212021.37807.j6t@kdbg.org> (raw)
In-Reply-To: <5d214c5180b20fa90d76cf0c2f064a14be1fb195.1235213803.git.trast@student.ethz.ch>
On Samstag, 21. Februar 2009, Thomas Rast wrote:
> I changed the tests
> to use
>
> test_must_fail git fsck 2>&1 | tee out
>
> instead, which both checks the exit status and makes the tests more
> verbose with -v.
This is wrong: It does not test the exist status. In a pipeline, the shell
looks only at the exit status of the last command. You really want this as
test_must_fail git fsck >out 2>&1 &&
If you want to have it more verbose, add 'cat out &&'. But IMHO that is
overengineered. If the test detects a regression in the future, it is easy to
inspect the file out if necessary.
-- Hannes
next prev parent reply other threads:[~2009-02-21 19:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 1:42 What's cooking in git.git (Feb 2009, #06; Wed, 18) Junio C Hamano
2009-02-19 11:13 ` [PATCH v2 0/8] Support coverage testing with GCC/gcov Thomas Rast
2009-02-19 11:13 ` [PATCH v2 1/8] " Thomas Rast
2009-02-19 11:13 ` [PATCH v2 2/8] Test that diff can read from stdin Thomas Rast
2009-02-19 11:13 ` [PATCH v2 3/8] Test diff --dirstat functionality Thomas Rast
2009-02-19 11:13 ` [PATCH v2 4/8] Test log --graph Thomas Rast
2009-02-19 11:13 ` [PATCH v2 5/8] Test fsck a bit harder Thomas Rast
2009-02-20 19:40 ` [PATCH v3] " Thomas Rast
2009-02-20 20:29 ` Johannes Sixt
2009-02-21 11:25 ` [PATCH v4] " Thomas Rast
2009-02-21 19:21 ` Johannes Sixt [this message]
2009-03-01 22:32 ` [PATCH v5] " Thomas Rast
2009-03-03 7:31 ` Junio C Hamano
2009-02-19 11:13 ` [PATCH v2 6/8] Test log --decorate Thomas Rast
2009-02-19 11:13 ` [PATCH v2 7/8] Test rev-list --parents/--children Thomas Rast
2009-02-19 11:13 ` [PATCH v2 8/8] Test git-patch-id Thomas Rast
2009-02-19 13:46 ` [PATCH v2 0/8] Support coverage testing with GCC/gcov Johannes Schindelin
2009-02-19 14:11 ` Thomas Rast
2009-02-19 14:09 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902212021.37807.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).