From: "Shawn O. Pearce" <spearce@spearce.org>
To: ferry.huberts@pelagic.nl
Cc: git@vger.kernel.org
Subject: Re: [EGIT] [PATCH 1/2] Make sure to set core.bare to false when cloning
Date: Mon, 23 Feb 2009 08:07:19 -0800 [thread overview]
Message-ID: <20090223160719.GJ22848@spearce.org> (raw)
In-Reply-To: <80065b1339c7b235b19fa1f5a40a58dca335ae91.1235228532.git.ferry.huberts@pelagic.nl>
ferry.huberts@pelagic.nl wrote:
> From: Ferry Huberts <ferry.huberts@pelagic.nl>
>
> This is to make sure that the git plugin sets up a clone
> in the same fashion as the CLI git clone command.
>
> Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
Thanks. "jgit clone" also needed this added. I did that in
a small followup patch.
Really though we need to fix the abstraction of Repository so there's
a notion of a bare repository, and a repository+worktree. And that
abstraction should then set the core.bare property accordingly
when creating a new repository (or new repository+worktree).
Unfortunately that hasn't happened yet...
> + /* we're setting up for a clone with a checkout */
> + local.getConfig().setBoolean("core", null, "bare", false);
> +
--
Shawn.
prev parent reply other threads:[~2009-02-23 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 15:17 [EGIT] [PATCH 0/2] Make sure to setup a clone the same as git-clone does ferry.huberts
2009-02-21 15:17 ` [EGIT] [PATCH 1/2] Make sure to set core.bare to false when cloning ferry.huberts
2009-02-21 15:17 ` [EGIT] [PATCH 2/2] Make sure to set up the default (pull) remote branch for master ferry.huberts
2009-02-23 16:09 ` Shawn O. Pearce
2009-02-23 16:13 ` Ferry Huberts (Pelagic)
2009-02-23 16:47 ` Shawn O. Pearce
2009-02-23 16:07 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090223160719.GJ22848@spearce.org \
--to=spearce@spearce.org \
--cc=ferry.huberts@pelagic.nl \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).