From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: John Tapsell <johnflux@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git push
Date: Wed, 25 Feb 2009 04:02:31 -0500 [thread overview]
Message-ID: <20090225090230.GA15919@coredump.intra.peff.net> (raw)
In-Reply-To: <7v4oyjc64z.fsf@gitster.siamese.dyndns.org>
On Tue, Feb 24, 2009 at 11:44:44PM -0800, Junio C Hamano wrote:
> > Presumably the obvious is that it might be confusing to existing
> > users? Perhaps, but it doesn't cause any damage. It's moving to a
> > 'safer' default.
>
> No, it is not merely confusing but is outright dangerous to people who
> expect the "matching refs" behaviour. It is not safer at all.
I think this is a very good reason not to change the default "push"
behavior.
> And this is not about punishing. It is about getting into a different
> mindset. Unlike CVS/SVN, committing and publishing can be made into
> different phases with git, and not pushing too early allows you produce a
> lot better results. "I want to push only this branch" is often (not
> always, but "often" stands with strong correlation) a sign that other
> things are not ready, and by definition you couldn't have thought through
> interactions between what you _think_ is ready (i.e. the current branch)
> and the other ones that are not ready. In other words, it is about
> encouraging people to think things through before publishing.
But I don't buy this at all. It is totally dependent on workflow and how
you use branches. That is, the "readiness" of two branches may be
totally unrelated. One may be a short-term branch for today's work, and
the other may be a long-running branch that you have made a WIP commit
on. You may even have that WIP commit sitting there for days.
When you think about "is my current branch ready to push?" there is no
reason for you to think of that other long-running branch that you
haven't seen for days.
-Peff
next prev parent reply other threads:[~2009-02-25 9:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 6:38 git push John Tapsell
2009-02-25 6:46 ` Jeff King
2009-02-25 7:01 ` Junio C Hamano
2009-02-25 7:09 ` John Tapsell
2009-02-25 7:44 ` Junio C Hamano
2009-02-25 9:02 ` Jeff King [this message]
2009-02-25 9:26 ` Junio C Hamano
2009-02-25 9:51 ` Jeff King
2009-02-25 9:08 ` John Tapsell
2009-02-25 9:49 ` Junio C Hamano
2009-02-25 10:06 ` John Tapsell
2009-02-25 9:34 ` Jay Soffian
2009-02-25 9:51 ` Junio C Hamano
2009-02-25 22:58 ` Finn Arne Gangstad
2009-03-05 8:45 ` Andreas Ericsson
2009-03-05 8:56 ` John Tapsell
2009-03-05 9:44 ` Finn Arne Gangstad
[not found] <CAJmx4Nxh_WzkO-S=SN9E=aODCrfs+QCig4sT+Q8eQ+Pv1hB2+w@mail.gmail.com>
2012-03-19 16:24 ` Kevin O'Brien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225090230.GA15919@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).