From: Jeff King <peff@peff.net>
To: Mike Hommey <mh@glandium.org>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] import memmem() with linear complexity from Gnulib
Date: Sat, 28 Feb 2009 22:41:23 -0500 [thread overview]
Message-ID: <20090301034123.GC30384@coredump.intra.peff.net> (raw)
In-Reply-To: <20090228224401.GA27262@glandium.org>
On Sat, Feb 28, 2009 at 11:44:01PM +0100, Mike Hommey wrote:
> > ---
> > Makefile | 1 +
> > compat/memmem.c | 103 +++++++++----
> > compat/str-two-way.h | 429 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 504 insertions(+), 29 deletions(-)
>
> Seeing how much memmem is being used in the codebase, is it really worth?
See earlier in the thread, where "git log -Stoken" is substantially
faster on Linux versus Windows (but some exact numbers before and after
on Windows would be nice to have in the commit message).
-Peff
next prev parent reply other threads:[~2009-03-01 3:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 6:52 [PATCH 0/4] Pickaxe search clean-up and optimization Junio C Hamano
2009-02-26 6:52 ` [PATCH 1/4] diffcore-pickaxe: refactor diffcore_pickaxe() Junio C Hamano
2009-02-27 23:58 ` René Scharfe
2009-02-26 6:52 ` [PATCH 2/4] diffcore-pickaxe: micro-optimize has_match() function Junio C Hamano
2009-02-26 6:52 ` [PATCH 3/4] diffcore-pickaxe: further refactor count_match() Junio C Hamano
2009-02-26 7:23 ` Kjetil Barvik
2009-02-28 1:13 ` René Scharfe
2009-02-28 1:25 ` Junio C Hamano
2009-02-28 6:08 ` Junio C Hamano
2009-02-28 13:10 ` René Scharfe
2009-02-28 17:40 ` Junio C Hamano
2009-02-28 18:15 ` René Scharfe
2009-02-28 19:16 ` [PATCH] import memmem() with linear complexity from Gnulib René Scharfe
2009-02-28 22:44 ` Mike Hommey
2009-03-01 3:41 ` Jeff King [this message]
2009-03-01 11:15 ` René Scharfe
2009-03-01 18:55 ` René Scharfe
2009-03-01 7:31 ` [PATCH 3/4] diffcore-pickaxe: further refactor count_match() Junio C Hamano
2009-03-01 10:53 ` René Scharfe
2009-02-26 6:52 ` [PATCH 4/4] diffcore-pickaxe: optimize by trimming common initial and trailing parts Junio C Hamano
2009-02-26 9:05 ` Junio C Hamano
2009-03-02 23:00 ` [PATCH 1/2] diffcore-pickaxe: use memmem() René Scharfe
2009-03-02 23:19 ` [PATCH 2/2] optimize compat/ memmem() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090301034123.GC30384@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).