git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Peter Krefting <peter@softwolves.pp.se>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] Windows: Assume all file names to be UTF-8 encoded.
Date: Mon, 2 Mar 2009 15:29:54 +0100	[thread overview]
Message-ID: <200903021530.01165.trast@student.ethz.ch> (raw)
In-Reply-To: <alpine.DEB.2.00.0903021452010.17877@perkele.intern.softwolves.pp.se>

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

Peter Krefting wrote:
> In the other project I worked on we ended up wrapping all file-related calls 
> in our own porting interface, and then let each platform we compiled for 
> implement their own methods for handling Unicode paths. For Windows it's 
> trivial since all APIs are Unicode. For Unix-like OSes it's tricky as you 
> have to take the locale settings into account, but fortunately the world is 
> slowly moving towards UTF-8 locales, which eases the pain a bit.

Have you thought about all the consequences this would have for the
*nix people here? [*]

Even if you pretend that Git did always enforce UTF-8 paths in its
trees, so that there's no backward compatibility to be cared for,
you're still in a world of hurt when trying to check out such paths
under a locale (or whatever setting might control this new encoding
logic) that does not support the whole range of UTF-8.

Like, say, the C locale.

Next you get to see to it that the users can spell all filenames even
if their locale doesn't let them, since they'll want to do things like
'git show $rev:$file' with them.

With backwards compatibility it's even worse as you're suddenly
imposing extra restrictions on what a valid filename in the repository
must look like.


[*] I'm _extremely_ tempted to write "people using non-broken OSes",
but let's pretend to be neutral for a second.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-03-02 14:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-02  8:47 [RFC PATCH] Windows: Assume all file names to be UTF-8 encoded Peter Krefting
2009-03-02 10:30 ` Johannes Sixt
2009-03-02 10:46   ` Peter Krefting
2009-03-02 10:56     ` Johannes Schindelin
2009-03-02 12:03       ` Peter Krefting
     [not found]         ` <a2633edd0903020512u5682e9am203f0faccd0acf6a@mail.gmail.com>
2009-03-02 13:57           ` Peter Krefting
2009-03-02 14:29             ` Thomas Rast [this message]
2009-03-02 20:41               ` Peter Krefting
2009-03-03  7:56                 ` Lars Noschinski
2009-03-03 11:54                   ` Peter Krefting
2009-03-03 16:29                     ` Lars Noschinski
2009-03-03 20:59                       ` Robin Rosenberg
2009-03-03  9:47                 ` Dmitry Potapov
2009-03-03 11:48                   ` Peter Krefting
2009-03-03 17:13                     ` Dmitry Potapov
2009-03-04 10:51                       ` Peter Krefting
2009-03-04 14:18                         ` Dmitry Potapov
2009-03-02 12:34     ` Johannes Sixt
2009-03-02 13:12       ` Peter Krefting
2009-03-02 19:58         ` Robin Rosenberg
2009-03-02 20:52           ` Peter Krefting
2009-03-02 21:21             ` Robin Rosenberg
2009-03-03  5:51               ` Peter Krefting
2009-03-03  9:43 ` Dmitry Potapov
2009-03-03 11:56   ` Peter Krefting
2009-03-07 10:38 ` Robin Rosenberg
  -- strict thread matches above, loose matches on Subject: below --
2009-03-03 18:25 John Dlugosz
2009-03-04 10:53 ` Peter Krefting
2009-03-04 19:34   ` John Dlugosz
2009-03-03 19:36 John Dlugosz
2009-03-03 20:39 John Dlugosz
2009-03-03 21:02 ` Dmitry Potapov
2009-03-03 21:56   ` John Dlugosz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903021530.01165.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=peter@softwolves.pp.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).