From: Jeff King <peff@peff.net>
To: Petri Hodju <petri.hodju@yumesystems.com>
Cc: Deskin Miller <deskinm@umich.edu>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] '%S' option for pretty printing to support --source
Date: Thu, 5 Mar 2009 04:17:58 -0500 [thread overview]
Message-ID: <20090305091758.GC30445@coredump.intra.peff.net> (raw)
In-Reply-To: <200903050918.29051.petri.hodju@yumesystems.com>
On Thu, Mar 05, 2009 at 09:18:28AM +0200, Petri Hodju wrote:
> +static void format_source(struct strbuf *sb, const struct commit *commit)
> +{
> + if (commit->util)
> + strbuf_addstr(sb, (char *) commit->util);
> +}
> +
Hmm. This is the second patch in the last few weeks to use commit->util
to carry information for --pretty=format: (I am cc'ing Deskin Miller,
who wrote the first).
They cannot both work, obviously. So we need to do one of:
- refactor the information out of commit->util to somewhere else
- allow multiple commit->util users somehow (which I think is a
potential performance problem -- the simplistic design is meant to
avoid things like allocation overhead)
- gracefully block concurrent use of conflicting features
-Peff
next prev parent reply other threads:[~2009-03-05 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 7:18 [PATCH] '%S' option for pretty printing to support --source Petri Hodju
2009-03-05 9:17 ` Jeff King [this message]
2009-03-05 10:59 ` Johannes Schindelin
2009-03-05 19:41 ` Deskin Miller
2009-03-06 5:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305091758.GC30445@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=deskinm@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=petri.hodju@yumesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).