From: "Shawn O. Pearce" <spearce@spearce.org>
To: Phil Lawrence <prlawrence@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Append ampersand to "Target" of lnk files created by do_cygwin_shortcut
Date: Mon, 9 Mar 2009 16:23:00 -0700 [thread overview]
Message-ID: <20090309232300.GK11989@spearce.org> (raw)
In-Reply-To: <530ac78e0903091509y5209dec9q4c716d1e400357f3@mail.gmail.com>
Phil Lawrence <prlawrence@gmail.com> wrote:
> From 0780db8d53bdd0bb02b154d23c3c80bcccc0d955 Mon Sep 17 00:00:00 2001
> From: Phil Lawrence <prlawrence@gmail.com>
> Date: Thu, 5 Mar 2009 17:56:58 -0600
> Subject: [PATCH] Append ampersand to "Target" of lnk files created by
> do_cygwin_shortcut
>
> The git-gui menu item "Repository | Create Desktop Icon" creates a
> shortcut (.lnk file) on the Windows desktop. The purpose of the
> created shortcut is to make it easy for a user to launch git-gui
> for a particular repo in the future.
Thanks. The patch was white space damaged, but being only 2
characters it was easier for me to just redo the change than
to ask you to resend the patch.
> @@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {
> $argv0]
> win32_create_lnk $fn [list \
> $sh -c \
> - "CHERE_INVOKING=1 source
> /etc/profile;[sq $me]" \
> + "CHERE_INVOKING=1 source
> /etc/profile;[sq $me] &" \
> ] \
> [file dirname [file normalize [gitdir]]]
> } err]} {
--
Shawn.
prev parent reply other threads:[~2009-03-09 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 22:09 [PATCH] Append ampersand to "Target" of lnk files created by do_cygwin_shortcut Phil Lawrence
2009-03-09 23:23 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309232300.GK11989@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=prlawrence@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox