From: "Shawn O. Pearce" <spearce@spearce.org>
To: Ruth Alkema <ruth@diasoft.nl>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [PATCH JGIT] fix for 'negative position' error
Date: Wed, 11 Mar 2009 08:24:42 -0700 [thread overview]
Message-ID: <20090311152442.GS11989@spearce.org> (raw)
In-Reply-To: <49B7D683.1070805@diasoft.nl>
Ruth Alkema <ruth@diasoft.nl> wrote:
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> index 4b7e10d..5340da9 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> @@ -253,7 +253,7 @@ private static synchronized final void getImpl(final WindowCursor curs,
> releaseMemory();
> runClearedWindowQueue();
>
> - wp.allocWindow(curs, id, id << windowSizeShift, wsz);
> + wp.allocWindow(curs, id, ((long) id) << windowSizeShift, wsz);
Ouch.
Thanks for the fix!
--
Shawn.
next prev parent reply other threads:[~2009-03-11 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 15:19 [PATCH JGIT] fix for 'negative position' error Ruth Alkema
2009-03-11 15:24 ` Shawn O. Pearce [this message]
2009-03-11 15:51 ` Ruth Alkema
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311152442.GS11989@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=ruth@diasoft.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).