From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Brian Campbell <brian.p.campbell@dartmouth.edu>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions
Date: Thu, 12 Mar 2009 16:09:23 +0100 [thread overview]
Message-ID: <20090312150923.GB14521@pengutronix.de> (raw)
In-Reply-To: <1236837389-35687-2-git-send-email-brian.p.campbell@dartmouth.edu>
Hello Brian,
one more minor nitpick:
On Thu, Mar 12, 2009 at 01:56:29AM -0400, Brian Campbell wrote:
> -[ -n "$name" ] || name="$(git symbolic-ref HEAD | sed 's#^refs/\(heads\|top-bases\)/##')"
> +[ -n "$name" ] || name="$(current_branch)"
current_branch doesn't look like the correct name. I'd prefer
current_tgpatch is better?! (For current_branch I would expect that
only refs/heads is stripped.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2009-03-12 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 5:56 [PATCH 1/2] [TopGit] Portability: Use tr instead of sed for translating spaces to newlines Brian Campbell
2009-03-12 5:56 ` [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions Brian Campbell
2009-03-12 6:55 ` Junio C Hamano
2009-03-12 7:45 ` Uwe Kleine-König
2009-03-12 15:00 ` Brian Campbell
2009-03-12 15:20 ` Uwe Kleine-König
2009-03-12 15:26 ` martin f krafft
2009-03-14 5:54 ` Junio C Hamano
2009-03-14 12:47 ` Uwe Kleine-König
2009-03-12 16:41 ` Brian Campbell
2009-03-12 17:04 ` Uwe Kleine-König
2009-03-12 15:09 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312150923.GB14521@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=brian.p.campbell@dartmouth.edu \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).