From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: [PATCH JGIT] Add "compare with Git Index" action.
Date: Fri, 13 Mar 2009 23:26:49 +0100 [thread overview]
Message-ID: <200903132326.49876.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <551f769b0903130328g49ce9971t53e1571d1b7de06c@mail.gmail.com>
fredag 13 mars 2009 11:28:48 skrev Yann Simon <yann.simon.fr@gmail.com>:
> 2009/3/11 Robin Rosenberg <robin.rosenberg.lists@dewire.com>:
> > Saving works, but the diff regions aren't updated on save.
>
> Sorry, I do not understand. Can you explain me more?
The compare ui marks the hunks when you bring it up. I think it should update on
save to the same view you would see when it is first brought up.
> > When there is a diff
> > this would give us the partial staging similar to git gui, if only (not your fault) the
> > commit dialog would allow us to make a distinction between changes in the
> > workdir and the index.
>
> Yes, I know that this patch is not very usefull for the moment.
> I was more looking for a review as an inclusion.
> And you found one bug. Thank you for that!
Well it is, sort of though it's not *the* solution.
-- robin
next prev parent reply other threads:[~2009-03-13 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 10:03 [PATCH JGIT] Add "compare with Git Index" action Yann Simon
2009-03-10 23:22 ` Robin Rosenberg
2009-03-13 10:28 ` Yann Simon
2009-03-13 22:26 ` Robin Rosenberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-03 14:04 Yann Simon
2009-03-07 0:31 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903132326.49876.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).