From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Thomas Rast <trast@student.ethz.ch>,
Matthias Nothhaft <matthias.nothhaft@googlemail.com>,
git@vger.kernel.org
Subject: Re: Transparently encrypt repository contents with GPG
Date: Tue, 17 Mar 2009 03:40:54 -0400 [thread overview]
Message-ID: <20090317074054.GA18475@coredump.intra.peff.net> (raw)
In-Reply-To: <49BE77DD.5020407@drmicha.warpmail.net>
On Mon, Mar 16, 2009 at 05:01:33PM +0100, Michael J Gruber wrote:
> Now, a simple test shows that git diff obviously does this when diffing
> HEAD to worktree:
>
> diff between HEAD and clean(worktree)
>
> Which is the right thing. It just seems so that textconv is not even
> called "in the wrong place of the chain", but messes the diff up in this
> way:
>
> diff between textconv(HEAD) and textconv(worktree)
>
> (I expected clean(textconv(worktree)) first, which would be wrong, too).
> I.e., the clean filter is ignored completely in the presence of textconv.
Yeah, I think this should probably be textconv(clean(worktree)) to match
the regular HEAD/worktree diff (if it isn't already). Can you put
together a test that shows the breakage?
-Peff
next prev parent reply other threads:[~2009-03-17 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 21:19 Transparently encrypt repository contents with GPG Matthias Nothhaft
2009-03-12 21:34 ` Sverre Rabbelier
2009-03-13 10:46 ` Michael J Gruber
2009-03-13 10:51 ` Sverre Rabbelier
2009-03-13 11:15 ` Thomas Rast
2009-03-13 11:17 ` Sverre Rabbelier
2009-03-13 13:56 ` Michael J Gruber
2009-03-13 14:19 ` Sverre Rabbelier
2009-03-13 17:13 ` Jeff King
2009-03-13 20:23 ` Junio C Hamano
2009-03-14 11:16 ` Michael J Gruber
2009-03-14 18:45 ` Junio C Hamano
2009-03-16 16:01 ` Michael J Gruber
2009-03-17 7:40 ` Jeff King [this message]
2009-03-17 8:22 ` Jeff King
2012-04-21 17:25 ` bigbear
2012-06-17 7:33 ` lalebarde
[not found] ` <CAL1Gx-Ufs8TNVeeefAXBnX-eCnEk_DC1w6oJVRPcMcStdL_+-Q@mail.gmail.com>
2012-06-18 20:03 ` lalebarde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317074054.GA18475@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthias.nothhaft@googlemail.com \
--cc=srabbelier@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).