From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [JGIT PATCH 3/4] Cap the number of open files in the
	WindowCache
Date: Tue, 17 Mar 2009 16:08:03 -0700
Message-ID: <20090317230803.GA23521@spearce.org>
References: <1237252570-8596-1-git-send-email-spearce@spearce.org> <1237252570-8596-3-git-send-email-spearce@spearce.org> <1237252570-8596-4-git-send-email-spearce@spearce.org> <200903172359.32595.robin.rosenberg.lists@dewire.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
X-From: git-owner@vger.kernel.org Wed Mar 18 00:09:48 2009
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1LjiPl-0007Wd-L7
	for gcvg-git-2@gmane.org; Wed, 18 Mar 2009 00:09:42 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751908AbZCQXIK (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 17 Mar 2009 19:08:10 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751849AbZCQXII
	(ORCPT <rfc822;git-outgoing>); Tue, 17 Mar 2009 19:08:08 -0400
Received: from george.spearce.org ([209.20.77.23]:52024 "EHLO
	george.spearce.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751709AbZCQXIF (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 17 Mar 2009 19:08:05 -0400
Received: by george.spearce.org (Postfix, from userid 1001)
	id A504B38221; Tue, 17 Mar 2009 23:08:03 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <200903172359.32595.robin.rosenberg.lists@dewire.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/113535>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> tisdag 17 mars 2009 02:16:09 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> 
> > If we detect a file open failure while opening a pack we halve
> > the number of permitted open files and try again, [...]
> 
> The output of getMessage isn't that simple to interpret. Here it is filename+" (Too many files open)",
> and on other platforms it is probably something else. This goes for the message part of most exceptions
> thrown from platform specific code like file i/o socket i/o etc. The type of exception is a FileNotFoundException,
> btw.
> 
> I wonder whether  your code works on any platform.

Arrrgh.
 
OK.  Maybe scrap that part of the patch then?

Its too bad they don't have a specific type of exception for this,
nor do they have a way to hold onto file descriptors under a type
like a SoftReference where the runtime can whack them if you have
too many.

I guess that's why Hadoop HBase just tells you to up your fd ulimit
to 32767.  :-)

-- 
Shawn.