From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: What's cooking in git.git (Mar 2009, #05; Tue, 17)
Date: Wed, 18 Mar 2009 01:52:22 -0400 [thread overview]
Message-ID: <20090318055222.GA17128@coredump.intra.peff.net> (raw)
In-Reply-To: <7vbprzo0si.fsf@gitster.siamese.dyndns.org>
On Tue, Mar 17, 2009 at 10:30:37PM -0700, Junio C Hamano wrote:
> * mv/parseopt-ls-files (Sat Mar 7 20:27:22 2009 -0500) 4 commits
> + ls-files: fix broken --no-empty-directory
> + t3000: use test_cmp instead of diff
> + parse-opt: migrate builtin-ls-files.
> + Turn the flags in struct dir_struct into a single variable
>
> The tip one was a subject for further discussion, but nothing is queued
> yet.
I am inclined to leave it as-is. The other sane option would be
converting it to use NONEG, as Miklos suggested.
Doing it right would probably mean adding a "this option is the opposite
of what we would usually do" flag to parse-options which would display
the option as "no-<option>" in the usage, and would reverse clearing and
setting the bit (i.e., --empty-directory would clear the HIDE_DIRECTORY
bit and --no-empty-directory would set it). But I don't think it is
worth the work to add a negatable version of an option that has never
existed before and which nobody has requested to use.
-Peff
next prev parent reply other threads:[~2009-03-18 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 5:30 What's cooking in git.git (Mar 2009, #05; Tue, 17) Junio C Hamano
2009-03-18 5:52 ` Jeff King [this message]
2009-03-18 7:47 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318055222.GA17128@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).