From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 00/12] Improve test coverage in revwalk
Date: Wed, 18 Mar 2009 07:34:59 +0100 [thread overview]
Message-ID: <200903180734.59435.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1237340451-31562-1-git-send-email-spearce@spearce.org>
onsdag 18 mars 2009 02:40:39 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> Most of these patches are to improve the test coverage within the
> revwalk package.
>
>
> The last commit points out what I feared, which is that a RevWalk
> with a PathFilter applied doesn't produce the same results that
> git-core would produce in the same situation. We're either missing
> some functions necessary to implement it, or we flat out produce
> a wrong graph in some cases.
>
> The tests are commented out because JUnit doesn't have a notion of
> "known broken". But I did leave in TODO comments. I'd like to
> apply the test, and then work later to improve it, but I'm open
> to suggestions.
If we'd switch to JUnit4/TestNG we could abuse the expected exception
annotation.
-- robin
next prev parent reply other threads:[~2009-03-18 6:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 1:40 [JGIT PATCH 00/12] Improve test coverage in revwalk Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 01/12] Fix copyright year in revwalk test file headers Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 02/12] Mark non-overridable methods of RevObject final Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 03/12] Change RevWalkTestCase to use RevCommit, not ObjectId Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 04/12] Test that RevFilter.MERGE_BASE cannot use a TreeFilter Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 05/12] Add unit tests for DateRevQueue Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 06/12] Add unit tests for FIFORevQueue Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 07/12] Add unit tests for LIFORevQueue Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 08/12] Add unit tests for AbstractRevQueue.EMPTY_QUEUE Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 09/12] Add tests for basic RevObject methods related to type, flags Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 10/12] Add tests for ObjectWalk Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 11/12] Add some basic logic tests for TreeFilter on RevWalk Shawn O. Pearce
2009-03-18 1:40 ` [JGIT PATCH 12/12] Implement git-core t/t6012-rev-list-simplify test case Shawn O. Pearce
2009-03-18 6:34 ` Robin Rosenberg [this message]
2009-03-18 9:21 ` [JGIT PATCH 00/12] Improve test coverage in revwalk Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903180734.59435.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).