git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] import-tars: separate author from committer
Date: Fri, 20 Mar 2009 07:43:52 -0700	[thread overview]
Message-ID: <20090320144352.GZ23521@spearce.org> (raw)
In-Reply-To: <1237543070-4909-1-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
> The import-tars script is typically employed to (re)create the past
> history of a project from stored tars. Although assigning authorship in
> these cases can be a somewhat arbitrary process, it makes sense to set
> the author to whoever created the tars in the first place (if it's
> known), and (s)he can in general be different from the committer
> (whoever is running the script).
> 
> Implement this by having separate author and committer data, making them
> settable from the usual GIT_* environment variables.
> ---
> 
> Or should I have made the ENV access a separate patch?

Looks fine to me.

Acked-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.

      reply	other threads:[~2009-03-20 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20  9:57 [PATCH] import-tars: separate author from committer Giuseppe Bilotta
2009-03-20 14:43 ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090320144352.GZ23521@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).