From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: git@vger.kernel.org
Cc: Dan Nicholson <dbn.lists@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Gerrit Pape <pape@smarden.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Pierre Habouzit <madcoder@debian.org>
Subject: git quiltimport and git apply fail importing the PREEMPT_RT patches
Date: Fri, 20 Mar 2009 20:06:17 +0100 [thread overview]
Message-ID: <20090320190617.GA28784@pengutronix.de> (raw)
Hello,
~/gsrc/linux-2.6$ git version
git version 1.5.6.5
(but with newer git I get the same)
~/gsrc/linux-2.6$ git checkout v2.6.29-rc8
Note: moving to "v2.6.29-rc8" which isn't a local branch
If you want to create a new branch from this checkout, you may do so
(now or later) by using -b with the checkout command again. Example:
git checkout -b <new_branch_name>
~/gsrc/linux-2.6$ wget -O - http://www.kernel.org/pub/linux/kernel/projects/rt/patch-2.6.29-rc8-rt2-broken-out.tar.bz2 | tar xjf -
~/gsrc/linux-2.6$ git quiltimport --author="do <nt@kn.ow>"
origin.patch.bz2
Patch is empty. Was it split wrong?
hhmmm, quilt seems to support packed patches.
After bunzip2 origin.patch.bz2 and editing series accordingly I get:
~/gsrc/linux-2.6$ git quiltimport --author="do <nt@kn.ow>"
origin.patch
.dotest/patch:12188: space before tab in indent.
.platform_data = &markeins_flash_data,
.dotest/patch:19521: trailing whitespace.
.dotest/patch:20778: trailing whitespace.
[PERF_COUNT_BRANCH_INSTRUCTIONS] = 0x230e4, /* BR_ISSUED */
.dotest/patch:21259: trailing whitespace.
[PERF_COUNT_BRANCH_INSTRUCTIONS] = 0x230e4, /* BR_ISSUED */
.dotest/patch:21548: trailing whitespace.
[PERF_COUNT_BRANCH_INSTRUCTIONS] = 0x410a0, /* BR_PRED */
error: cannot apply binary patch to 'Documentation/logo.gif' without full index line
error: Documentation/logo.gif: patch does not apply
The hunk for Documentation/logo.gif looks as follows:
diff --git a/Documentation/logo.gif b/Documentation/logo.gif
deleted file mode 100644
index 2eae75f..0000000
Binary files a/Documentation/logo.gif and /dev/null differ
For me this looks complete enough to be applicable:
~/gsrc/linux-2.6$ git ls-tree HEAD:Documentation | grep logo.gif
100644 blob 2eae75fecfb965f49065c680063a40c594736ee5 logo.gif
(For these who want to look into the 2nd issue, here is an easier
reproduction recipe:
~/gsrc/linux-2.6$ git apply --index -C1 - << EOF
> diff --git a/Documentation/logo.gif b/Documentation/logo.gif
> deleted file mode 100644
> index 2eae75f..0000000
> Binary files a/Documentation/logo.gif and /dev/null differ
> EOF
error: cannot apply binary patch to 'Documentation/logo.gif' without full index line
error: Documentation/logo.gif: patch does not apply
)
For the first issue I have a patch that I'll send as a reply to this
mail. Luckily this works around the second problem, too :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2009-03-20 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 19:06 Uwe Kleine-König [this message]
2009-03-20 19:18 ` [PATCH] quiltimport: use quilt to do patch/series parsing and application Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320190617.GA28784@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=dbn.lists@gmail.com \
--cc=ebiederm@xmission.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).