From: Christian Couder <chriscool@tuxfamily.org>
To: "David J. Mellor" <dmellor@whistlingcat.com>
Cc: gitster@pobox.com, git@vger.kernel.org,
Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH] Documentation: Reworded example text in git-bisect.txt.
Date: Sat, 21 Mar 2009 05:28:32 +0100 [thread overview]
Message-ID: <200903210528.32392.chriscool@tuxfamily.org> (raw)
In-Reply-To: <1237520134-18044-1-git-send-email-dmellor@whistlingcat.com>
Le vendredi 20 mars 2009, David J. Mellor a écrit :
[...]
> @@ -94,14 +95,14 @@ the bisection state).
> Bisect visualize
> ~~~~~~~~~~~~~~~~
>
> -During the bisection process, you issue the command:
> +To see the currently remaining suspects in 'gitk', the following command
> +is issued during the bisection process:
I think it's better to avoid the passive tone, for example like this:
"To see the currently remaining suspects in 'gitk', you issue the following
command during the bisection process:"
> ------------
> $ git bisect visualize
> ------------
[...]
> @@ -173,8 +175,8 @@ using the "'<commit1>'..'<commit2>'" notation. For
> example: $ git bisect skip v2.5..v2.6
> ------------
>
> -would mean that no commit between `v2.5` excluded and `v2.6` included
> -can be tested.
> +The effect of this would be that no commit between `v2.5` excluded and
> +`v2.6` included could be tested.
I'd prefer something like:
"This tells the bisect process that no commit between `v2.5` excluded and
`v2.6` included can be tested."
Otherwise it looks good to me.
Thanks,
Christian.
next prev parent reply other threads:[~2009-03-21 4:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 3:35 [PATCH] Documentation: Reworded example text in git-bisect.txt David J. Mellor
2009-03-20 8:59 ` Michael J Gruber
2009-03-21 4:28 ` Christian Couder [this message]
2009-03-22 21:39 ` David J. Mellor
2009-03-23 0:23 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903210528.32392.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=dmellor@whistlingcat.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).