From: Jeff King <peff@peff.net>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, gitster@pobox.com, spearce@spearce.org
Subject: Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Date: Sun, 22 Mar 2009 18:33:09 -0400 [thread overview]
Message-ID: <20090322223309.GA22428@sigill.intra.peff.net> (raw)
In-Reply-To: <49C65DF1.8030608@web.de>
On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:
> When checking out or cloning via git gui, the post-checkout
> hook is not called. This is a bit unexpected ...
>
> The reason is that git gui uses git read-tree with the -u
> option and not git checkout and git clone. I changed git
> read-tree to call the post-checkout hook when called with
> -u and it seems to solve the problem. I would make a patch
> for that if you want.
>
> But is this the right way to do this? Seems like we could
> surprise some users of git read-tree with this change in
> behaviour.
No, I think plumbing should not generally call hooks. The right solution
would be to have git-gui call the post-checkout hook.
-Peff
next prev parent reply other threads:[~2009-03-22 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 15:49 [RFC] git gui doesn't call post-checkout hook on checkout or clone Jens Lehmann
2009-03-22 22:33 ` Jeff King [this message]
2009-03-23 0:18 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090322223309.GA22428@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).