From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC] git gui doesn't call post-checkout hook on checkout or clone
Date: Sun, 22 Mar 2009 17:18:27 -0700 [thread overview]
Message-ID: <20090323001827.GG23521@spearce.org> (raw)
In-Reply-To: <20090322223309.GA22428@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Sun, Mar 22, 2009 at 04:49:05PM +0100, Jens Lehmann wrote:
>
> > When checking out or cloning via git gui, the post-checkout
> > hook is not called. This is a bit unexpected ...
...
> > But is this the right way to do this? Seems like we could
> > surprise some users of git read-tree with this change in
> > behaviour.
>
> No, I think plumbing should not generally call hooks. The right solution
> would be to have git-gui call the post-checkout hook.
+1. git-gui should be invoking the hook. It doesn't. Patches are
welcome. I don't really have time these days for doing my own
development on git-gui, but well coded patches are still accepted.
--
Shawn.
prev parent reply other threads:[~2009-03-23 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 15:49 [RFC] git gui doesn't call post-checkout hook on checkout or clone Jens Lehmann
2009-03-22 22:33 ` Jeff King
2009-03-23 0:18 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323001827.GG23521@spearce.org \
--to=spearce@spearce.org \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).