Re: [PATCH 1/8] Documentation: move callouts.xsl to manpage-{base,normal}.xsl

[Jeff King <peff@peff.net>]

On Tue, Mar 24, 2009 at 03:04:19AM -0500, Chris Johnsen wrote:

>  Documentation/Makefile           |    2 +-
>  Documentation/callouts.xsl       |   30 ------------------------------
>  Documentation/manpage-base.xsl   |   30 ++++++++++++++++++++++++++++++
>  Documentation/manpage-normal.xsl |   30 ++++++++++++++++++++++++++++++
>  4 files changed, 61 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/callouts.xsl
>  create mode 100644 Documentation/manpage-base.xsl
>  create mode 100644 Documentation/manpage-normal.xsl

This is definitely a good change, though it would also be fine to
actually munge the contents in the same patch rather than duplicate them
(i.e., actually _split_ callouts.xsl instead of copying it to two
places).

I think it would have been much easier to read, though, by turning on
rename detection in format-patch (i.e., "-M"). That yields:

---
 Documentation/Makefile                             |    2 +-
 Documentation/{callouts.xsl => manpage-base.xsl}   |    0
 Documentation/{callouts.xsl => manpage-normal.xsl} |    0
 3 files changed, 1 insertions(+), 1 deletions(-)
 copy Documentation/{callouts.xsl => manpage-base.xsl} (100%)
 rename Documentation/{callouts.xsl => manpage-normal.xsl} (100%)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 144ec32..e1562e3 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -41,7 +41,7 @@ man7dir=$(mandir)/man7
 
 ASCIIDOC=asciidoc
 ASCIIDOC_EXTRA =
-MANPAGE_XSL = callouts.xsl
+MANPAGE_XSL = manpage-normal.xsl
 INSTALL?=install
 RM ?= rm -f
 DOC_REF = origin/man
diff --git a/Documentation/callouts.xsl b/Documentation/manpage-base.xsl
similarity index 100%
copy from Documentation/callouts.xsl
copy to Documentation/manpage-base.xsl
diff --git a/Documentation/callouts.xsl b/Documentation/manpage-normal.xsl
similarity index 100%
rename from Documentation/callouts.xsl
rename to Documentation/manpage-normal.xsl
-- 
1.6.2.1.459.g5b99e