From: Jeff King <peff@peff.net>
To: Chris Johnsen <chris_johnsen@pobox.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/8] Documentation: rename docbook-xsl-172 attribute to git-asciidoc-no-roff
Date: Tue, 24 Mar 2009 05:04:40 -0400 [thread overview]
Message-ID: <20090324090440.GC1799@coredump.intra.peff.net> (raw)
In-Reply-To: <1237881866-5497-4-git-send-email-chris_johnsen@pobox.com>
On Tue, Mar 24, 2009 at 03:04:21AM -0500, Chris Johnsen wrote:
> It seems that the ability to use raw roff codes in asciidoc.conf
> was eliminated by docbook-xsl 1.72.0 _and later_. Unlike the
> 1.72.0-specific XSLT problem, this behavior was not reverted in
> later releases.
>
> This patch aims to make it clear that the affected asciidoc
> attribute (flag) can be reasonably used with docbook-xsl versions
> other than 1.72.0.
Great, this looks like a definite improvement. Should we be respecting
more DOCBOOK_XSL_* variables than just 172, then? I.e.,:
> +# For docbook-xsl ...
> +# -1.68.1, set ASCIIDOC_NO_ROFF? (based on changelog from 1.73.0)
> +# 1.69.0-1.71.1, no extra settings are needed?
> +# 1.72.0, set DOCBOOK_XSL_172.
> +# 1.73.0-, set ASCIIDOC_NO_ROFF
DOCBOOK_XSL_173, etc?
I don't know that we need to cover _every_ version, but if we can have
specific knobs for individual features (like ASCIIDOC_NO_ROFF), then
maybe it makes sense to aggregate the settings for those knobs for a few
common versions.
-Peff
next prev parent reply other threads:[~2009-03-24 9:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 8:04 [PATCH 0/8] Documentation: XSLT/asciidoc.conf cleanup; tty literals Chris Johnsen
2009-03-24 8:04 ` [PATCH 1/8] Documentation: move callouts.xsl to manpage-{base,normal}.xsl Chris Johnsen
2009-03-24 8:51 ` Jeff King
2009-03-24 19:36 ` Chris Johnsen
2009-03-26 9:40 ` Jeff King
2009-03-24 8:04 ` [PATCH 2/8] Documentation: use parametrized manpage-base.xsl with manpage-{1.72,normal}.xsl Chris Johnsen
2009-03-24 8:57 ` Jeff King
2009-03-24 19:42 ` Chris Johnsen
2009-03-24 8:04 ` [PATCH 3/8] Documentation: rename docbook-xsl-172 attribute to git-asciidoc-no-roff Chris Johnsen
2009-03-24 9:04 ` Jeff King [this message]
2009-03-24 19:48 ` Chris Johnsen
2009-03-26 9:43 ` Jeff King
2009-03-26 16:47 ` Junio C Hamano
2009-03-26 18:49 ` Michael J Gruber
2009-03-24 8:04 ` [PATCH 4/8] Documentation: move quieting params into manpage-base.xsl Chris Johnsen
2009-03-24 9:18 ` Jeff King
2009-03-25 4:21 ` [PATCH 1/2] Documentation/Makefile: make most operations "quiet" Chris Johnsen
2009-03-25 4:21 ` [PATCH 2/2] Documentation/Makefile: break up texi pipeline Chris Johnsen
2009-03-25 4:28 ` [PATCH 1/2] Documentation/Makefile: make most operations "quiet" Jeff King
2009-03-25 9:55 ` Chris Johnsen
2009-03-24 8:04 ` [PATCH 5/8] Documentation: move "spurious .sp" code into manpage-base.xsl Chris Johnsen
2009-03-24 8:04 ` [PATCH 6/8] Documentation: asciidoc.conf: always use <literallayout> for [blocktext] Chris Johnsen
2009-03-24 8:04 ` [PATCH 7/8] Documentation: asciidoc.conf: fix verse block with block titles Chris Johnsen
2009-03-24 8:04 ` [PATCH 8/8] Documentation: option to render literal text as bold for manpages Chris Johnsen
2009-03-26 8:59 ` [PATCH 0/8] Documentation: XSLT/asciidoc.conf cleanup; tty literals Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324090440.GC1799@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chris_johnsen@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).