From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, John Tapsell <johnflux@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 05/10] rev-list: make "show_bisect_vars" non static
Date: Thu, 26 Mar 2009 05:55:35 +0100 [thread overview]
Message-ID: <20090326055535.9b970cff.chriscool@tuxfamily.org> (raw)
and declare it in "bisect.h" as we will use this function later.
While at it, rename its last argument "show_all" instead of
"bisect_find_all".
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
bisect.h | 2 ++
builtin-rev-list.c | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/bisect.h b/bisect.h
index 60b2fe1..860a15c 100644
--- a/bisect.h
+++ b/bisect.h
@@ -5,4 +5,6 @@ extern struct commit_list *find_bisection(struct commit_list *list,
int *reaches, int *all,
int find_all);
+extern int show_bisect_vars(int reaches, int all, int show_all);
+
#endif
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 74d22b4..c700c34 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -226,7 +226,7 @@ static int estimate_bisect_steps(int all)
return (e < 3 * x) ? n : n - 1;
}
-static int show_bisect_vars(int reaches, int all, int bisect_find_all)
+int show_bisect_vars(int reaches, int all, int show_all)
{
int cnt;
char hex[41];
@@ -246,9 +246,10 @@ static int show_bisect_vars(int reaches, int all, int bisect_find_all)
cnt = all - reaches;
if (cnt < reaches)
cnt = reaches;
+
strcpy(hex, sha1_to_hex(revs.commits->item->object.sha1));
- if (bisect_find_all) {
+ if (show_all) {
traverse_commit_list(&revs, show_commit, show_object);
printf("------\n");
}
--
1.6.2.1.317.g3d804
reply other threads:[~2009-03-26 4:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326055535.9b970cff.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).