From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] difftool: add support for an extended revision syntax
Date: Fri, 27 Mar 2009 11:16:15 -0700 [thread overview]
Message-ID: <20090327181547.GA4933@gmail.com> (raw)
In-Reply-To: <7vab76evaj.fsf@gitster.siamese.dyndns.org>
On 0, Junio C Hamano <gitster@pobox.com> wrote:
> David Aguilar <davvid@gmail.com> writes:
>
> > I noticed that my patches for "add tests to difftool" and "add
> > the -y shortcut for --no-prompt" were in git.git's pu branch
> > the other day but aren't there anymore. Was that intentional?
>
> Yes, it makes 'pu' not pass the self test.
Oops, was this related to your suggestions about the patch
that added the tests? I sent a v2 patch that included the
fixups. I'll try running the tests when I get back home to my
Linux machine on Monday (I'm currently in Chicago on a trip)
though I'm not sure if I'd be able to reproduce the failure if
it's platform-specific.
Sorry 'bout that.
--
David
next prev parent reply other threads:[~2009-03-27 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 10:15 [PATCH] difftool: add support for an extended revision syntax David Aguilar
2009-03-23 14:51 ` Michael J Gruber
2009-03-23 16:33 ` David Aguilar
2009-03-23 16:46 ` Michael J Gruber
2009-03-23 23:22 ` Junio C Hamano
2009-03-23 23:33 ` David Aguilar
2009-03-23 23:50 ` Junio C Hamano
2009-03-27 15:59 ` Jakub Narebski
2009-03-27 16:28 ` David Aguilar
2009-03-27 17:21 ` Junio C Hamano
2009-03-27 18:16 ` David Aguilar [this message]
2009-03-27 17:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327181547.GA4933@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).