From: Finn Arne Gangstad <finnag@pvv.org>
To: "Santi Béjar" <santi@agolina.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] Rename push.default to push.style
Date: Mon, 30 Mar 2009 10:01:15 +0200 [thread overview]
Message-ID: <20090330080115.GA19142@pvv.org> (raw)
In-Reply-To: <1238281804-30290-5-git-send-email-santi@agolina.net>
On Sun, Mar 29, 2009 at 12:10:04AM +0100, Santi Béjar wrote:
> push.default was too generic, and also didn't specify if it was about
> remote, refspec, branches, behaviour...
> [...]
> "You can specify what action you want to take in this case, and",
> - "avoid seeing this message again, by configuring 'push.default' to:",
> + "avoid seeing this message again, by configuring 'push.style' to:",
> " 'nothing' : Do not push anything",
> " 'matching' : Push all matching branches (default)",
> " 'tracking' : Push the current branch to whatever it is tracking",
> [...]
I don't think "push.style" is an improvement. "style" sounds like it
affects all pushes. This configuration variable says what push should
do when no refspec is given and none are configured, so the word
"default" should be in there at least. Maybe "defaultref" would have
been better?
Some people may have started setting push.default already, so changing
the name may cause additional grief.
- Finn Arne
next prev parent reply other threads:[~2009-03-30 8:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 23:10 [PATCH 0/4] push.default and branch.<name>.{remote,merge} changes Santi Béjar
2009-03-28 23:10 ` [PATCH 1/4] Documentation: enhance branch.<name>.{remote,merge} Santi Béjar
2009-03-29 1:38 ` Jay Soffian
2009-03-29 10:54 ` Santi Béjar
2009-03-28 23:10 ` [PATCH 2/4] Documentation: push.default applies to all remotes Santi Béjar
2009-03-28 23:10 ` [PATCH 3/4] Documentation: branch.*.merge can also afect 'git-push' Santi Béjar
2009-03-28 23:10 ` [PATCH 4/4] Rename push.default to push.style Santi Béjar
2009-03-30 8:01 ` Finn Arne Gangstad [this message]
2009-03-30 8:23 ` Johannes Schindelin
2009-03-30 9:00 ` Santi Béjar
2009-03-30 9:07 ` Santi Béjar
2009-03-30 10:29 ` Jeff King
2009-03-30 12:50 ` Santi Béjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330080115.GA19142@pvv.org \
--to=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).