From: Jeff King <peff@peff.net>
To: "Santi Béjar" <santi@agolina.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Finn Arne Gangstad <finnag@pvv.org>,
git@vger.kernel.org
Subject: Re: [PATCH 4/4] Rename push.default to push.style
Date: Mon, 30 Mar 2009 06:29:30 -0400 [thread overview]
Message-ID: <20090330102739.GA5163@sigill.intra.peff.net> (raw)
In-Reply-To: <adf1fd3d0903300200v65393b1bif0050392aa44652e@mail.gmail.com>
On Mon, Mar 30, 2009 at 11:00:03AM +0200, Santi Béjar wrote:
> >> This configuration variable says what push should do
> >> when no refspec is given and none are configured, so the word "default"
> >> should be in there at least. Maybe "defaultref" would have been better?
>
> I don't see the point of the word default, a lot of configuration is
> to set the default value. Git has branch.name.remote, not
> branch.name.defaultremote, or user.email, not user.defaultemail,...
The usual case is two layers of options: command line and config
options. Thus "git push <remote>" overrides "branch.*.remote".
But in this case there are actually _three_ layers: command line,
branch.*.push, and now push.default. I think a name like "push.mode"
doesn't make clear the fact that it will never be looked at if you have
"branch.*.push" set up.
I think you have a point that "default" is vague, but "defaultMode"
would be better than simply "mode".
-Peff
next prev parent reply other threads:[~2009-03-30 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 23:10 [PATCH 0/4] push.default and branch.<name>.{remote,merge} changes Santi Béjar
2009-03-28 23:10 ` [PATCH 1/4] Documentation: enhance branch.<name>.{remote,merge} Santi Béjar
2009-03-29 1:38 ` Jay Soffian
2009-03-29 10:54 ` Santi Béjar
2009-03-28 23:10 ` [PATCH 2/4] Documentation: push.default applies to all remotes Santi Béjar
2009-03-28 23:10 ` [PATCH 3/4] Documentation: branch.*.merge can also afect 'git-push' Santi Béjar
2009-03-28 23:10 ` [PATCH 4/4] Rename push.default to push.style Santi Béjar
2009-03-30 8:01 ` Finn Arne Gangstad
2009-03-30 8:23 ` Johannes Schindelin
2009-03-30 9:00 ` Santi Béjar
2009-03-30 9:07 ` Santi Béjar
2009-03-30 10:29 ` Jeff King [this message]
2009-03-30 12:50 ` Santi Béjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330102739.GA5163@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).