git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt.net>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Magnus Bäck" <baeck@swipnet.se>, "Johannes Sixt" <j6t@kdbg.org>,
	git@vger.kernel.org
Subject: Re: Implementing stat() with FindFirstFile()
Date: Tue, 31 Mar 2009 00:07:10 +0200	[thread overview]
Message-ID: <20090330220709.GA68118@macbook.lan> (raw)
In-Reply-To: <20090330051118.GA2681@atjola.homenet>

On Mon, Mar 30, 2009 at 07:11:18AM +0200, Björn Steinbrink wrote:
> On 2009.03.30 02:52:47 +0200, Johannes Schindelin wrote:
> > On Mon, 30 Mar 2009, Magnus Bäck wrote:
> > > On Friday, March 27, 2009 at 03:25 CET,
> > > Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > > On Thu, 26 Mar 2009, Magnus Bäck wrote:
> > > > > I'd be very surprised if ZwQueryDirectoryFile() hasn't always been
> > > > > around (I just verified ntdll.dll from NT 4.0), so that's not a
> > > > > worry. Don't know why MSDN reports it as introduced in XP.
> > > >
> > > > As the current maintainer of msysGit, I refuse to have something in
> > > > the installer I ship that relies on not-at-all guaranteed interfaces.
> > > 
> > > Although I do appreciate the importance of guaranteed interfaces,
> > > I am also pragmatic. An incompatible change in ntdll.dll would break
> > > vast amounts of programs, including cygwin. There is a lot to be said
> > > about Microsoft and their APIs, but I don't think they have a habit of
> > > changing ABIs or function semantics for userland libraries that have
> > > been around for 15 years.
> > 
> > Had you pointed to some document that states that the function has been in 
> > all NT-based versions, that would have done the trick.
> 
> Not official documentation, but at least from some MS guy it seems:
> http://www.osronline.com/showThread.cfm?link=73086 (last message).
> 
> Apparently, it was in NT3.x, but they document only what's actually
> defined in the header.

How about runtime checking? You could do GetProcAddress(...) and if you
don't get it use the old behaviour. I mean if it really is faster why
not let Users of recent systems benefit from it.

cheers Heiko

  reply	other threads:[~2009-03-30 22:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 15:47 Implementing stat() with FindFirstFile() Magnus Bäck
2009-03-21 19:55 ` Johannes Sixt
2009-03-24 21:54   ` Magnus Bäck
2009-03-26  7:15     ` Johannes Sixt
2009-03-26 21:39       ` Magnus Bäck
2009-03-27  2:25         ` Johannes Schindelin
2009-03-29 22:48           ` Magnus Bäck
2009-03-30  0:52             ` Johannes Schindelin
2009-03-30  5:11               ` Björn Steinbrink
2009-03-30 22:07                 ` Heiko Voigt [this message]
2009-03-30 23:29                   ` Johannes Schindelin
2009-03-31 20:32                     ` Magnus Bäck
2009-03-31 20:49                       ` Johannes Schindelin
2009-04-01  9:28 ` Nazri Ramliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090330220709.GA68118@macbook.lan \
    --to=hvoigt@hvoigt.net \
    --cc=B.Steinbrink@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=baeck@swipnet.se \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).